Attachment 369748 Details for Bug 197845 – Patch

[patch] Patch

bug-197845-20190513130713.patch (text/plain), 3.40 KB, created by Michael Catanzaro on 2019-05-13 11:07:14 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2019-05-13 11:07:14 PDT

Size: 3.40 KB

patch

obsolete

>Subversion Revision: 245234
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index c2913aebb2b9677c13d5e9ea6fcf6af5e5ed8ae9..c0a8dc73ae741bcd207286dfa4dc24345142426d 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-05-13  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        [WPE][GTK] Enable hyperlink auditing
>+        https://bugs.webkit.org/show_bug.cgi?id=197845
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/API/glib/WebKitSettings.cpp:
>+        (webkit_settings_class_init):
>+
> 2019-05-13  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         Unreviewed, fix unused variable warnings in release builds
>diff --git a/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp b/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
>index 657b1febf5d1ee326126704cc21da95e6437f8c8..c2ed6831da59a4cbba1f3a3d5932d1788b4d7b83 100644
>--- a/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
>+++ b/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
>@@ -779,7 +779,7 @@ static void webkit_settings_class_init(WebKitSettingsClass* klass)
>                                     g_param_spec_boolean("enable-hyperlink-auditing",
>                                                          _("Enable hyperlink auditing"),
>                                                          _("Whether <a ping> should be able to send pings."),
>-                                                         FALSE,
>+                                                         TRUE,
>                                                          readWriteConstructParamFlags));
> 
>     /**
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 17d6ca023e23ab60f85b6d0b54b10b8c21716311..c39e96af40dc082b2c527349b7410075f2182104 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-05-13  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        [WPE][GTK] Enable hyperlink auditing
>+        https://bugs.webkit.org/show_bug.cgi?id=197845
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
>+        (testWebKitSettings):
>+
> 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
> 
>         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp b/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp
>index d1156f384678feed2642f4a9769de951cf5b90ac..5a4a7e4a424e48bb65ac8cbb09b68a17447b1242 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp
>+++ b/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp
>@@ -96,10 +96,10 @@ static void testWebKitSettings(Test*, gconstpointer)
>     webkit_settings_set_javascript_can_open_windows_automatically(settings, TRUE);
>     g_assert_true(webkit_settings_get_javascript_can_open_windows_automatically(settings));
> 
>-    // By default hyper link auditing is disabled.
>-    g_assert_false(webkit_settings_get_enable_hyperlink_auditing(settings));
>-    webkit_settings_set_enable_hyperlink_auditing(settings, TRUE);
>+    // By default hyper link auditing is enabled.
>     g_assert_true(webkit_settings_get_enable_hyperlink_auditing(settings));
>+    webkit_settings_set_enable_hyperlink_auditing(settings, FALSE);
>+    g_assert_false(webkit_settings_get_enable_hyperlink_auditing(settings));
> 
>     // Default font family is "sans-serif".
>     g_assert_cmpstr(webkit_settings_get_default_font_family(settings), ==, "sans-serif");

Actions: View | Formatted Diff | Diff

Attachments on bug 197845: 369748