Attachment 369743 Details for Bug 197843 – Patch

[patch] Patch

bug-197843.diff (text/plain), 1.87 KB, created by Don Olmstead on 2019-05-13 10:10:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Don Olmstead

Created: 2019-05-13 10:10:13 PDT

Size: 1.87 KB

patch

obsolete

>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index c2913aebb2b..b2390cd2d45 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-13  Don Olmstead  <don.olmstead@sony.com>
>+
>+        decidePolicyForInstallMissingMediaPluginsPermissionRequest requires GStreamer
>+        https://bugs.webkit.org/show_bug.cgi?id=197843
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/API/wpe/PageClientImpl.cpp:
>+        ENABLE(VIDEO) && USE(GSTREAMER)
>+        * UIProcess/WebPageProxy.h:
>+        Cleanup the declaration.
>+
> 2019-05-13  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         Unreviewed, fix unused variable warnings in release builds
>diff --git a/Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp b/Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp
>index d05b42fc617..a91ff0f7b02 100644
>--- a/Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp
>+++ b/Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp
>@@ -334,7 +334,7 @@ void PageClientImpl::derefView()
> {
> }
> 
>-#if ENABLE(VIDEO)
>+#if ENABLE(VIDEO) && USE(GSTREAMER)
> bool PageClientImpl::decidePolicyForInstallMissingMediaPluginsPermissionRequest(InstallMissingMediaPluginsPermissionRequest&)
> {
>     return false;
>diff --git a/Source/WebKit/UIProcess/WebPageProxy.h b/Source/WebKit/UIProcess/WebPageProxy.h
>index 8d8fe812238..5809fcfef9c 100644
>--- a/Source/WebKit/UIProcess/WebPageProxy.h
>+++ b/Source/WebKit/UIProcess/WebPageProxy.h
>@@ -1986,10 +1986,8 @@ private:
>     void fixedLayoutSizeDidChange(WebCore::IntSize fixedLayoutSize) { m_fixedLayoutSize = fixedLayoutSize; }
> 
>     void imageOrMediaDocumentSizeChanged(const WebCore::IntSize&);
>-#if ENABLE(VIDEO)
>-#if USE(GSTREAMER)
>+#if ENABLE(VIDEO) && USE(GSTREAMER)
>     void requestInstallMissingMediaPlugins(const String& details, const String& description);
>-#endif
> #endif
> 
>     void startURLSchemeTask(URLSchemeTaskParameters&&);

Actions: View | Formatted Diff | Diff

Attachments on bug 197843: 369743