Attachment 369636 Details for Bug 197812 – Patch

[patch] Patch

bug-197812-20190511000408.patch (text/plain), 2.23 KB, created by Aakash Jain on 2019-05-10 21:04:10 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-05-10 21:04:10 PDT

Size: 2.23 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 245204)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-05-10  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-app] Status bubble should turn orange when any build step fails
>+        https://bugs.webkit.org/show_bug.cgi?id=197812
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
>+        (StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
>+        (StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
>+
> 2019-05-10  Chris Dumez  <cdumez@apple.com>
> 
>         Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
>Index: Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py	(revision 245204)
>+++ Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py	(working copy)
>@@ -71,7 +71,10 @@ class StatusBubble(View):
>         builder_full_name = build.builder_name.replace('-', ' ')
> 
>         if build.result is None:  # In-progress build
>-            bubble['state'] = 'started'
>+            if self._does_build_contains_any_failed_step(build):
>+                bubble['state'] = 'provisional-fail'
>+            else:
>+                bubble['state'] = 'started'
>             bubble['details_message'] = 'Build is in-progress. Recent messages:\n\n' + self._steps_messages(build)
>         elif build.result == Buildbot.SUCCESS:
>             if is_parent_build:
>@@ -150,6 +153,12 @@ class StatusBubble(View):
>     def _should_display_step(self, step):
>         return not filter(lambda step_to_hide: re.search(step_to_hide, step.state_string), StatusBubble.STEPS_TO_HIDE)
> 
>+    def _does_build_contains_any_failed_step(self, build):
>+        for step in build.step_set.all():
>+            if step.result and step.result != Buildbot.SUCCESS:
>+                return True
>+        return False
>+
>     def _most_recent_step_message(self, build):
>         recent_step = build.step_set.last()
>         if not recent_step:

Actions: View | Formatted Diff | Diff

Attachments on bug 197812: 369636