Attachment 369577 Details for Bug 197760 – Patch

[patch] Patch

bug-197760-20190510120254.patch (text/plain), 1.64 KB, created by Geoffrey Garen on 2019-05-10 12:02:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Geoffrey Garen

Created: 2019-05-10 12:02:54 PDT

Size: 1.64 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 245061)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-05-09  Geoffrey Garen  <ggaren@apple.com>
>+
>+        Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files
>+        https://bugs.webkit.org/show_bug.cgi?id=197760
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We have all the data we need, and this crash is happening more than
>+        expected.
>+
>+        * platform/sql/SQLiteDatabase.cpp:
>+        (WebCore::SQLiteDatabase::open):
>+
> 2019-05-08  Simon Fraser  <simon.fraser@apple.com>
> 
>         Implement backing-sharing in compositing layers, allowing overlap layers to paint into the backing store of another layer
>Index: Source/WebCore/platform/sql/SQLiteDatabase.cpp
>===================================================================
>--- Source/WebCore/platform/sql/SQLiteDatabase.cpp	(revision 245061)
>+++ Source/WebCore/platform/sql/SQLiteDatabase.cpp	(working copy)
>@@ -150,8 +150,10 @@ bool SQLiteDatabase::open(const String& 
>         useWALJournalMode();
> 
>     String shmFileName = makeString(filename, "-shm"_s);
>-    if (FileSystem::fileExists(shmFileName))
>-        RELEASE_ASSERT(FileSystem::isSafeToUseMemoryMapForPath(shmFileName));
>+    if (FileSystem::fileExists(shmFileName)) {
>+        if (!FileSystem::isSafeToUseMemoryMapForPath(shmFileName))
>+            RELEASE_LOG_FAULT(SQLDatabase, "Opened an SQLite database with a Class A -shm file. This will trigger a crash when the user locks the device. (%s)", shmFileName.latin1().data());
>+    }
> 
>     return isOpen();
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 197760: 369530 | 369577 | 369757