Attachment 369573 Details for Bug 197789 – Patch

[patch] Patch

bug-197789-20190510112718.patch (text/plain), 1.54 KB, created by Sihui Liu on 2019-05-10 11:27:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2019-05-10 11:27:19 PDT

Size: 1.54 KB

patch

obsolete

>Subversion Revision: 245178
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 227dd90f3d2d7b9e43df6a822c56314aae81f7bd..c954f398f3b94a980213df988a8887b9a3b761eb 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-05-10  Sihui Liu  <sihui_liu@apple.com>
>+
>+        Make database shm file safe for mmap
>+        https://bugs.webkit.org/show_bug.cgi?id=197789
>+        <rdar://problem/50628434>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We know shm file can be NSFileProtectionComplete with previously added assertion.
>+
>+        * platform/sql/SQLiteDatabase.cpp:
>+        (WebCore::SQLiteDatabase::open):
>+
> 2019-05-10  Antti Koivisto  <antti@apple.com>
> 
>         Event region generation needs to know about backing-sharing
>diff --git a/Source/WebCore/platform/sql/SQLiteDatabase.cpp b/Source/WebCore/platform/sql/SQLiteDatabase.cpp
>index 579646aa3ac52e5b178093b6081389227e950edc..66e6959e056c099adef1df4c65118965efb6a701 100644
>--- a/Source/WebCore/platform/sql/SQLiteDatabase.cpp
>+++ b/Source/WebCore/platform/sql/SQLiteDatabase.cpp
>@@ -150,8 +150,10 @@ bool SQLiteDatabase::open(const String& filename, OpenMode openMode)
>         useWALJournalMode();
> 
>     String shmFileName = makeString(filename, "-shm"_s);
>+
>+    // FIXME: Remove this once database framework does this for us.
>     if (FileSystem::fileExists(shmFileName))
>-        RELEASE_ASSERT(FileSystem::isSafeToUseMemoryMapForPath(shmFileName));
>+        FileSystem::makeSafeToUseMemoryMapForPath(shmFileName);
> 
>     return isOpen();
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 197789: 369573