Attachment 369499 Details for Bug 196307 – Patch

[patch] Patch

bug-196307-20190509111341.patch (text/plain), 4.19 KB, created by Sihui Liu on 2019-05-09 11:13:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2019-05-09 11:13:42 PDT

Size: 4.19 KB

patch

obsolete

>Subversion Revision: 245144
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index b303f73a11f4e5e0b4c7ac4d5298ffd22fbcd855..c4053615d01c5dd5046eb0d295f23303b0ffb2e1 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-05-09  Sihui Liu  <sihui_liu@apple.com>
>+
>+        [ Mac WK2 iOS Sim] Layout Test http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=196307
>+        <rdar://problem/49345360>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The removal of IndexedDB data could take some time. Deletion of database files is performed on the database 
>+        thread and resource load statistic gets updated in a callback on the main thread. In this test, there is a race 
>+        between the callback and the check of statistics result. We should delay the check to make sure IndexedDB 
>+        deletion finishes.
>+
>+        * http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html:
>+        * platform/ios-simulator-wk2/TestExpectations:
>+        * platform/mac-wk2/TestExpectations:
>+
> 2019-05-09  Daniel Bates  <dabates@apple.com>
> 
>         [iOS] Unable to commit search on MSN.com, qq.com, or sina.com.cn using enter key (hardware or software keyboard)
>diff --git a/LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html b/LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html
>index 1d08a996962784a61818b120871b8a75dfd179f6..7fe0d76c7c2c4a379060a48d0a9a03a092a1a036 100644
>--- a/LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html
>+++ b/LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html
>@@ -153,7 +153,8 @@
> 
>     function processWebsiteDataAndContinue() {
>         testRunner.statisticsProcessStatisticsAndDataRecords();
>-        checkWebsiteDataAndContinue();
>+        // To ensure deletion of IndexedDB data finishes on the database thread.
>+        setTimeout(checkWebsiteDataAndContinue, 1000);
>     }
> 
>     function checkWebsiteDataAndContinue() {
>diff --git a/LayoutTests/platform/ios-simulator-wk2/TestExpectations b/LayoutTests/platform/ios-simulator-wk2/TestExpectations
>index 594ce74d8991c92af31b2fa56704f87c6fe87ac3..e1e84aca490160b501bd39f6cea7b5672e11fd40 100644
>--- a/LayoutTests/platform/ios-simulator-wk2/TestExpectations
>+++ b/LayoutTests/platform/ios-simulator-wk2/TestExpectations
>@@ -69,8 +69,6 @@ webkit.org/b/196298 fast/viewport/ios/use-minimum-device-width-for-page-without-
> 
> webkit.org/b/162975 http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache.html [ Pass Failure ]
> 
>-webkit.org/b/196307 http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html [ Pass Failure ]
>-
> webkit.org/b/196112 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold.html [ Pass ImageOnlyFailure ]
> webkit.org/b/196112 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-double-struck.html [ Pass ImageOnlyFailure ]
> webkit.org/b/196112 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-italic.html [ Pass ImageOnlyFailure ]
>diff --git a/LayoutTests/platform/mac-wk2/TestExpectations b/LayoutTests/platform/mac-wk2/TestExpectations
>index 4241ad914561da5aaab31afc2bab0d4836a6040e..bf537564eacb08f541bc3ad6df81e1fd666baeae 100644
>--- a/LayoutTests/platform/mac-wk2/TestExpectations
>+++ b/LayoutTests/platform/mac-wk2/TestExpectations
>@@ -914,8 +914,6 @@ webkit.org/b/194253 scrollingcoordinator/scrolling-tree/fixed-inside-frame.html
> 
> webkit.org/b/194916 fast/mediastream/MediaStream-video-element.html [ Pass Failure ]
> 
>-webkit.org/b/196307 http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html [ Pass Failure ]
>-
> webkit.org/b/196376 storage/domstorage/localstorage/private-browsing-affects-storage.html [ Pass Failure ]
> 
> webkit.org/b/194780 http/wpt/webauthn/public-key-credential-create-success-hid.https.html [ Pass Failure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 196307: 369498 | 369499 | 369559 | 370256