Attachment 369498 Details for Bug 196307 – Patch

[patch] Patch

bug-196307-20190509110856.patch (text/plain), 2.17 KB, created by Sihui Liu on 2019-05-09 11:08:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2019-05-09 11:08:56 PDT

Size: 2.17 KB

patch

obsolete

>Subversion Revision: 245144
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index b303f73a11f4e5e0b4c7ac4d5298ffd22fbcd855..9ccfcda62dd4618fc55cb11e2b5b562bc8ce7593 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-05-09  Sihui Liu  <sihui_liu@apple.com>
>+
>+        [ Mac WK2 iOS Sim] Layout Test http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=196307
>+        <rdar://problem/49345360>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The removal of IndexedDB data could take some time. Deletion of database files is performed on the database 
>+        thread and resource load statistic gets updated in a callback on the main thread. In this test, there is a race 
>+        between the callback and the check of statistics result. We should delay the check to make sure IndexedDB 
>+        deletion finishes.
>+
>+        * http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html:
>+
> 2019-05-09  Daniel Bates  <dabates@apple.com>
> 
>         [iOS] Unable to commit search on MSN.com, qq.com, or sina.com.cn using enter key (hardware or software keyboard)
>diff --git a/LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html b/LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html
>index 1d08a996962784a61818b120871b8a75dfd179f6..7fe0d76c7c2c4a379060a48d0a9a03a092a1a036 100644
>--- a/LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html
>+++ b/LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html
>@@ -153,7 +153,8 @@
> 
>     function processWebsiteDataAndContinue() {
>         testRunner.statisticsProcessStatisticsAndDataRecords();
>-        checkWebsiteDataAndContinue();
>+        // To ensure deletion of IndexedDB data finishes on the database thread.
>+        setTimeout(checkWebsiteDataAndContinue, 1000);
>     }
> 
>     function checkWebsiteDataAndContinue() {

Actions: View | Formatted Diff | Diff

Attachments on bug 196307: 369498 | 369499 | 369559 | 370256