Attachment 369488 Details for Bug 197737 – Patch

[patch] Patch

bug-197737-20190509090458.patch (text/plain), 2.96 KB, created by Aakash Jain on 2019-05-09 06:04:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-05-09 06:04:59 PDT

Size: 2.96 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 245133)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2019-05-09  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Fix formatting issues and typos
>+        https://bugs.webkit.org/show_bug.cgi?id=197737
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (CompileWebKit.evaluateCommand): Removed extra empty line.
>+        * BuildSlaveSupport/ews-build/steps_unittest.py:
>+        (TestRunWebKitPerlTests): Fixed typo.
>+        * BuildSlaveSupport/ews-app/ews/models/step.py:
>+        (Step.save_step): Changed log level to info so that it is logged in production.
>+
> 2019-05-09  Xan LÃ³pez  <xan@igalia.com>
> 
>         [CMake] Detect SSE2 at compile time
>Index: Tools/BuildSlaveSupport/ews-app/ews/models/step.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-app/ews/models/step.py	(revision 245133)
>+++ Tools/BuildSlaveSupport/ews-app/ews/models/step.py	(working copy)
>@@ -64,7 +64,7 @@ class Step(models.Model):
> 
>         # Save the new step data, e.g.: step start event.
>         Step(step_uid, build_uid, result, state_string, started_at, complete_at).save()
>-        _log.debug('Saved step {} in database for build: {}'.format(step_uid, build_uid))
>+        _log.info('Saved step {} in database for build: {}'.format(step_uid, build_uid))
>         return SUCCESS
> 
>     @classmethod
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 245133)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -617,7 +617,6 @@ class CompileWebKit(shell.Compile):
>         else:
>             self.build.addStepsAfterCurrentStep([ArchiveBuiltProduct(), UploadBuiltProduct()])
> 
>-
>         return super(CompileWebKit, self).evaluateCommand(cmd)
> 
> 
>Index: Tools/BuildSlaveSupport/ews-build/steps_unittest.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(revision 245133)
>+++ Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(working copy)
>@@ -318,7 +318,7 @@ class TestRunBindingsTests(BuildStepMixi
>         return self.runStep()
> 
> 
>-class TestunWebKitPerlTests(BuildStepMixinAdditions, unittest.TestCase):
>+class TestRunWebKitPerlTests(BuildStepMixinAdditions, unittest.TestCase):
>     def setUp(self):
>         self.longMessage = True
>         return self.setUpBuildStep()
>@@ -1234,7 +1234,7 @@ Testing completed, Exit status: 3
>         self.expectOutcome(result=FAILURE, state_string='4 api tests failed or timed out (failure)')
>         return self.runStep()
> 
>-    def test_unexpecte_failure(self):
>+    def test_unexpected_failure(self):
>         self.setupStep(RunAPITests())
>         self.setProperty('fullPlatform', 'mac-mojave')
>         self.setProperty('platform', 'mac')

Actions: View | Formatted Diff | Diff

Attachments on bug 197737: 369488