Attachment 369485 Details for Bug 185764 – Patch to add set_device_scale_factor implementation declared by libwpe

[patch] Patch to add set_device_scale_factor implementation declared by libwpe

hidpi.diff (text/plain), 1.68 KB, created by Ryan Walklin on 2019-05-09 05:01:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryan Walklin

Created: 2019-05-09 05:01:22 PDT

Size: 1.68 KB

patch

obsolete

>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index b808218101..b02a85433f 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-05-09  Ryan Walklin  <ryan@testtoast.com>
>+
>+        [WPE] Rendering on a HiDPI display looks scaled up instead of rendered at 2x
>+        https://bugs.webkit.org/show_bug.cgi?id=185764
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add a function to the wpe_view_backend_client struct which accepts a device scale factor from
>+        Wayland and calls setIntrinsicDeviceScaleFactor() for the current View.Page object. The
>+        function definition has been added to libwpe 1.3.
>+
>+        * UIProcess/API/wpe/WPEView.cpp:
>+        (WKWPE::m_backend): Add set_device_scale_factor implementation declared by libwpe.
>+
> 2019-05-08  Antoine Quint  <graouts@apple.com>
> 
>         [iOS] Correctly handle overlapping regions for elements with a touch-action property
>diff --git a/Source/WebKit/UIProcess/API/wpe/WPEView.cpp b/Source/WebKit/UIProcess/API/wpe/WPEView.cpp
>index 0bc7cb8d7c..f9610fde87 100644
>--- a/Source/WebKit/UIProcess/API/wpe/WPEView.cpp
>+++ b/Source/WebKit/UIProcess/API/wpe/WPEView.cpp
>@@ -100,8 +100,13 @@ View::View(struct wpe_view_backend* backend, const API::PageConfiguration& baseC
>                 flags.add(WebCore::ActivityState::IsInWindow);
>             view.setViewState(flags);
>         },
>-        // padding
>-        nullptr,
>+        // set device scale
>+        [](void* data, float scale)
>+        {
>+            auto& view = *reinterpret_cast<View*>(data);
>+            view.page().setIntrinsicDeviceScaleFactor(scale);
>+        },
>+        // padding,
>         nullptr,
>         nullptr
>     };

Actions: View | Formatted Diff | Diff

Attachments on bug 185764: 340688 | 343499 | 343891 | 347582 | 347583 | 347605 | 369485 | 369525 | 369667