Attachment 369409 Details for Bug 197704 – Patch

[patch] Patch

bug-197704-20190508122912.patch (text/plain), 1.92 KB, created by youenn fablet on 2019-05-08 12:29:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-05-08 12:29:13 PDT

Size: 1.92 KB

patch

obsolete

>Subversion Revision: 244961
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 3dad5edfcaa9bda77efe75d3f1834001dcff8386..c6a2d7efa00a578ada56853b97de5974c560a841 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-05-08  Youenn Fablet  <youenn@apple.com>
>+
>+        Use clampTo in AVVideoCaptureSource::setSizeAndFrameRateWithPreset
>+        https://bugs.webkit.org/show_bug.cgi?id=197704
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use clampTo as suggested in bug 196214 review.
>+        No change of behavior.
>+
>+        * platform/mediastream/mac/AVVideoCaptureSource.mm:
>+        (WebCore::AVVideoCaptureSource::setSizeAndFrameRateWithPreset):
>+
> 2019-05-07  Youenn Fablet  <youenn@apple.com>
> 
>         getUserMedia framerate unusable under low light in iOS 12.2
>diff --git a/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm b/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
>index 106734ffe905ab29ac844b835307e145008d39d3..a5376430a2308d84ada452a6250a892c88158188 100644
>--- a/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
>+++ b/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
>@@ -326,10 +326,7 @@ void AVVideoCaptureSource::setSizeAndFrameRateWithPreset(IntSize requestedSize,
>             if (!frameRateRange)
>                 return;
> 
>-            if (requestedFrameRate < frameRateRange.minFrameRate)
>-                requestedFrameRate = frameRateRange.minFrameRate;
>-            else if (requestedFrameRate > frameRateRange.maxFrameRate)
>-                requestedFrameRate = frameRateRange.maxFrameRate;
>+            requestedFrameRate = clampTo(requestedFrameRate, frameRateRange.minFrameRate, frameRateRange.maxFrameRate);
> 
>             ALWAYS_LOG_IF(loggerPtr(), LOGIDENTIFIER, "setting frame rate to ", requestedFrameRate);
>             [device() setActiveVideoMinFrameDuration: CMTimeMake(1, requestedFrameRate)];

Actions: View | Formatted Diff | Diff

Attachments on bug 197704: 369409