Attachment 369369 Details for Bug 197410 – Patch

[patch] Patch

bug-197410-20190508112441.patch (text/plain), 2.16 KB, created by Philippe Normand on 2019-05-08 03:24:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Philippe Normand

Created: 2019-05-08 03:24:42 PDT

Size: 2.16 KB

patch

obsolete

>Subversion Revision: 245008
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 26177d0480c0ee5f982bbef8fd38d16ff051bbee..afc622743fcd49f15bcbb3c7a420ba6b2a71bd90 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-05-08  Philippe Normand  <pnormand@igalia.com>
>+
>+        REGRESSION(r243197): [GStreamer] Error playing redirected streams
>+        https://bugs.webkit.org/show_bug.cgi?id=197410
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Revert the change introduced in r243197 that was checking the
>+        redirected URI instead of the original URI. Non-main URIs should
>+        be ignored only when they are HLS (or similar) fragments.
>+
>+        Test http/tests/security/canvas-remote-read-remote-video-hls.html still passes.
>+
>+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
>+        (WebCore::MediaPlayerPrivateGStreamer::handleMessage):
>+
> 2019-05-07  Antti Koivisto  <antti@apple.com>
> 
>         <body> with overflow:hidden CSS is scrollable on iOS
>diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>index 319f36621d7b012ec536013380d45138b5d0bc66..4a6dabfbd48957dd47bb1ca55496a89646f858d1 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>@@ -1351,9 +1351,8 @@ void MediaPlayerPrivateGStreamer::handleMessage(GstMessage* message)
>         }
> #endif
>         else if (gst_structure_has_name(structure, "http-headers")) {
>-            const char* redirectionUri = gst_structure_get_string(structure, "redirection-uri");
>-            const char* uri = redirectionUri ? redirectionUri : gst_structure_get_string(structure, "uri");
>-            if (uri) {
>+            GST_DEBUG_OBJECT(pipeline(), "Processing HTTP headers: %" GST_PTR_FORMAT, structure);
>+            if (const char* uri = gst_structure_get_string(structure, "uri")) {
>                 URL url(URL(), uri);
>                 convertToInternalProtocol(url);
>                 m_origins.add(SecurityOrigin::create(url));

Flags:

cgarcia: review+
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 197410: 369369 | 369377