Attachment 369346 Details for Bug 197452 – Patch

[patch] Patch

bug-197452-20190507180239.patch (text/plain), 19.31 KB, created by Megan Gardner on 2019-05-07 18:02:40 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Megan Gardner

Created: 2019-05-07 18:02:40 PDT

Size: 19.31 KB

patch

obsolete

>Subversion Revision: 245021
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1b2d9db69bb644da635812d997e714244795a906..80df32f692df3cc0fe0b0c44583806eff8bff193 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,30 @@
>+2019-04-30  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Add quirks to emulate undo and redo in hidden editable areas on some websites
>+        https://bugs.webkit.org/show_bug.cgi?id=197452
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        UI change, not testable.
>+
>+        We need to send synthetic keyboard events to the web process to emulate undo and redo
>+        key combinations for when we are trying to get our undo and redo UI to work
>+        on rich editing websites that only listen to keystrokes, and don't let us use our
>+        undo manager to help manage the input content.
>+
>+        * page/EventHandler.cpp:
>+        (WebCore::EventHandler::keyEvent):
>+        * platform/PlatformKeyboardEvent.h:
>+        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
>+        (WebCore::PlatformKeyboardEvent::isSyntheticEvent):
>+        (WebCore::PlatformKeyboardEvent::setSyntheticEvent):
>+        * platform/ios/KeyEventIOS.mm:
>+        (WebCore::PlatformKeyboardEvent::currentStateOfModifierKeys):
>+        * platform/ios/PlatformEventFactoryIOS.mm:
>+        (WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
>+        * platform/mac/PlatformEventFactoryMac.mm:
>+        (WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
>+
> 2019-05-07  Antoine Quint  <graouts@apple.com>
> 
>         [Pointer Events] isPrimary property of pointercancel events should match previous events for that pointer
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 3fb03b1295f2d11aa66a1bb09145c1ed300888cd..3345e243730acfdb389dc8c066059d9d451d18bb 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,37 @@
>+2019-04-30  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Add quirks to emulate undo and redo in hidden editable areas on some websites
>+        https://bugs.webkit.org/show_bug.cgi?id=197452
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We need to make our own undo manager to allow undo even when 
>+        the manager is empty. This is to interface with rich editing 
>+        websites that don't actually interface with our undo abilities.
>+        Then we need to generate synthetic undo and redo in the web process.
>+
>+        * UIProcess/WebPageProxy.cpp:
>+        (WebKit::WebPageProxy::isCurrentURLHost const):
>+        * UIProcess/WebPageProxy.h:
>+        * UIProcess/ios/WKContentView.mm:
>+        (-[WKNSUndoManager initWithContentView:]):
>+        (-[WKNSUndoManager canUndo]):
>+        (-[WKNSUndoManager canRedo]):
>+        (-[WKNSUndoManager undo]):
>+        (-[WKNSUndoManager redo]):
>+        (-[WKContentView undoManager]):
>+        * UIProcess/ios/WKContentViewInteraction.h:
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView generateSyntheticUndoRedo:]):
>+        (-[WKContentView hasHiddenContentEditable]):
>+        * UIProcess/ios/WebPageProxyIOS.mm:
>+        (WebKit::WebPageProxy::generateSyntheticUndoRedo):
>+        * WebProcess/WebPage/WebPage.h:
>+        * WebProcess/WebPage/WebPage.messages.in:
>+        * WebProcess/WebPage/ios/WebPageIOS.mm:
>+        (WebKit::WebPage::handleEditingKeyboardEvent):
>+        (WebKit::WebPage::generateSyntheticUndoRedo):
>+
> 2019-05-07  Chris Dumez  <cdumez@apple.com>
> 
>         Rename ConnectionMac.mm to ConnectionCocoa.mm since it is used on both macOS and iOS
>diff --git a/Source/WebCore/page/EventHandler.cpp b/Source/WebCore/page/EventHandler.cpp
>index 22f099cb2b85e0859b1974be9d3336667d48b9f1..27901f73cc22bcaa453c49d423391a5d60a314f9 100644
>--- a/Source/WebCore/page/EventHandler.cpp
>+++ b/Source/WebCore/page/EventHandler.cpp
>@@ -3155,6 +3155,9 @@ bool EventHandler::isKeyEventAllowedInFullScreen(const PlatformKeyboardEvent& ke
> 
> bool EventHandler::keyEvent(const PlatformKeyboardEvent& keyEvent)
> {
>+    bool shiftKey, ctrlKey, altKey, metaKey;
>+    keyEvent.getCurrentModifierState(shiftKey, ctrlKey, altKey, metaKey);
>+
>     Document* topDocument = m_frame.document() ? &m_frame.document()->topDocument() : nullptr;
>     MonotonicTime savedLastHandledUserGestureTimestamp;
>     bool savedUserDidInteractWithPage = topDocument ? topDocument->userDidInteractWithPage() : false;
>diff --git a/Source/WebCore/page/Quirks.cpp b/Source/WebCore/page/Quirks.cpp
>index b1f1ffdb5ae4011c0a96f1f19c92b4e2e9cbfe94..3a06920cbe9affc9d95d1b45d032e370a41a216a 100644
>--- a/Source/WebCore/page/Quirks.cpp
>+++ b/Source/WebCore/page/Quirks.cpp
>@@ -235,8 +235,21 @@ static bool shouldSuppressAutocorrectionAndAutocaptializationInHiddenEditableAre
>     return false;
> }
> 
>+static bool shouldEmulateUndoRedoInHiddenEditableAreasForHost(const StringView&)
>+{
>+    return false;
>+}
>+
> #endif
> 
>+bool Quirks::shouldEmulateUndoRedoInHiddenEditableAreas() const
>+{
>+    if (!needsQuirks())
>+        return false;
>+
>+    return shouldEmulateUndoRedoInHiddenEditableAreasForHost(m_document->topDocument().url().host());
>+}
>+
> bool Quirks::shouldSuppressAutocorrectionAndAutocaptializationInHiddenEditableAreas() const
> {
>     if (!needsQuirks())
>diff --git a/Source/WebCore/page/Quirks.h b/Source/WebCore/page/Quirks.h
>index e920bc326797ee888842e91fd36b76461343c4c8..06c4477ca5f907758cd7a551652e327c757e2a27 100644
>--- a/Source/WebCore/page/Quirks.h
>+++ b/Source/WebCore/page/Quirks.h
>@@ -53,6 +53,7 @@ public:
>     bool needsInputModeNoneImplicitly(const HTMLElement&) const;
> 
>     WEBCORE_EXPORT bool shouldSuppressAutocorrectionAndAutocaptializationInHiddenEditableAreas() const;
>+    WEBCORE_EXPORT bool shouldEmulateUndoRedoInHiddenEditableAreas() const;
>     WEBCORE_EXPORT bool isTouchBarUpdateSupressedForHiddenContentEditable() const;
>     WEBCORE_EXPORT bool isNeverRichlyEditableForTouchBar() const;
> 
>diff --git a/Source/WebCore/platform/PlatformKeyboardEvent.h b/Source/WebCore/platform/PlatformKeyboardEvent.h
>index b7a02a90349fe1730bc733d1a98409a534c9b53f..85c272c364a5de6461f210d1fb10487bc6253d4d 100644
>--- a/Source/WebCore/platform/PlatformKeyboardEvent.h
>+++ b/Source/WebCore/platform/PlatformKeyboardEvent.h
>@@ -128,6 +128,9 @@ namespace WebCore {
>         bool isAutoRepeat() const { return m_autoRepeat; }
>         bool isKeypad() const { return m_isKeypad; }
>         bool isSystemKey() const { return m_isSystemKey; }
>+        
>+        bool isSyntheticEvent() { return m_isSyntheticEvent; }
>+        void setSyntheticEvent() { m_isSyntheticEvent = true; }
> 
>         WEBCORE_EXPORT static bool currentCapsLockState();
>         WEBCORE_EXPORT static void getCurrentModifierState(bool& shiftKey, bool& ctrlKey, bool& altKey, bool& metaKey);
>@@ -190,6 +193,8 @@ namespace WebCore {
>         bool m_autoRepeat;
>         bool m_isKeypad;
>         bool m_isSystemKey;
>+        
>+        bool m_isSyntheticEvent { false };
> 
> #if PLATFORM(COCOA)
> #if !PLATFORM(IOS_FAMILY)
>diff --git a/Source/WebKit/Shared/FocusedElementInformation.cpp b/Source/WebKit/Shared/FocusedElementInformation.cpp
>index bc2bc3335d2f4c2fdd744ad7be8230500d8851dc..95ff5f91afa7c4783b3979c16a7180dcc029953b 100644
>--- a/Source/WebKit/Shared/FocusedElementInformation.cpp
>+++ b/Source/WebKit/Shared/FocusedElementInformation.cpp
>@@ -104,6 +104,7 @@ void FocusedElementInformation::encode(IPC::Encoder& encoder) const
>     encoder << suggestedColors;
> #endif
> #endif
>+    encoder << needsQuirkyUndoManager;
> }
> 
> bool FocusedElementInformation::decode(IPC::Decoder& decoder, FocusedElementInformation& result)
>@@ -222,6 +223,8 @@ bool FocusedElementInformation::decode(IPC::Decoder& decoder, FocusedElementInfo
>         return false;
> #endif
> #endif
>+    if (!decoder.decode(result.needsQuirkyUndoManager))
>+        return false;
> 
>     return true;
> }
>diff --git a/Source/WebKit/Shared/FocusedElementInformation.h b/Source/WebKit/Shared/FocusedElementInformation.h
>index 188d5a7e9cb5041d25e2053f4aed948ddba34af2..04e0330fb9a064c0116e6c68b89688478483cb15 100644
>--- a/Source/WebKit/Shared/FocusedElementInformation.h
>+++ b/Source/WebKit/Shared/FocusedElementInformation.h
>@@ -136,6 +136,7 @@ struct FocusedElementInformation {
>     Vector<WebCore::Color> suggestedColors;
> #endif
> #endif
>+    bool needsQuirkyUndoManager { false };
> 
>     FocusedElementIdentifier focusedElementIdentifier { 0 };
> 
>diff --git a/Source/WebKit/UIProcess/WebPageProxy.h b/Source/WebKit/UIProcess/WebPageProxy.h
>index 8720eebd7fb7ccf0b37388ab8bf2fdfed7b1c19b..4401cb94b4180302ee2a0fc15194ba96e08a3ee5 100644
>--- a/Source/WebKit/UIProcess/WebPageProxy.h
>+++ b/Source/WebKit/UIProcess/WebPageProxy.h
>@@ -550,6 +550,7 @@ public:
>     bool canShowMIMEType(const String& mimeType);
> 
>     String currentURL() const;
>+    bool isCurrentURLHost(const String& base) const;
> 
>     float topContentInset() const { return m_topContentInset; }
>     void setTopContentInset(float);
>@@ -720,6 +721,7 @@ public:
>     void requestEvasionRectsAboveSelection(CompletionHandler<void(const Vector<WebCore::FloatRect>&)>&&);
>     void updateSelectionWithDelta(int64_t locationDelta, int64_t lengthDelta, CompletionHandler<void()>&&);
>     void requestDocumentEditingContext(WebKit::DocumentEditingContextRequest, CompletionHandler<void(WebKit::DocumentEditingContext)>&&);
>+    void generateSyntheticUndoRedo(bool isUndo);
> #if ENABLE(DATA_INTERACTION)
>     void didHandleDragStartRequest(bool started);
>     void didHandleAdditionalDragItemsRequest(bool added);
>@@ -727,7 +729,7 @@ public:
>     void requestAdditionalItemsForDragSession(const WebCore::IntPoint& clientPosition, const WebCore::IntPoint& globalPosition, WebCore::DragSourceAction allowedActions);
>     void didConcludeEditDrag(Optional<WebCore::TextIndicatorData>);
> #endif
>-#endif
>+#endif // PLATFORM(IOS_FAMILY)
> #if ENABLE(DATA_DETECTION)
>     void setDataDetectionResult(const DataDetectionResult&);
> #endif
>diff --git a/Source/WebKit/UIProcess/ios/WKContentView.mm b/Source/WebKit/UIProcess/ios/WKContentView.mm
>index 6b2d9f9644f7b934d71bf17c3ae588c7c238b439..06db56ba116e0922e479ff1c572ef0ece50e938d 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentView.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentView.mm
>@@ -59,6 +59,7 @@
> #import <WebCore/InspectorOverlay.h>
> #import <WebCore/NotImplemented.h>
> #import <WebCore/PlatformScreen.h>
>+#import <WebCore/Quirks.h>
> #import <pal/spi/cocoa/QuartzCoreSPI.h>
> #import <wtf/RetainPtr.h>
> #import <wtf/text/TextStream.h>
>@@ -172,6 +173,41 @@ - (instancetype)initWithFrame:(CGRect)frame
> 
> @end
> 
>+@interface WKQuirkyNSUndoManager : NSUndoManager
>+@property (readonly, weak) WKContentView *contentView;
>+@end
>+
>+@implementation WKQuirkyNSUndoManager
>+- (instancetype)initWithContentView:(WKContentView *)contentView
>+{
>+    if (!(self = [super init]))
>+        return nil;
>+    _contentView = contentView;
>+    return self;
>+}
>+
>+- (BOOL)canUndo 
>+{
>+    return YES;
>+}
>+
>+- (BOOL)canRedo 
>+{
>+    return YES;
>+}
>+
>+- (void)undo 
>+{
>+    [self.contentView generateSyntheticUndoRedo:YES];
>+}
>+
>+- (void)redo 
>+{
>+    [self.contentView generateSyntheticUndoRedo:NO];
>+}
>+
>+@end
>+
> @implementation WKContentView {
>     std::unique_ptr<WebKit::PageClientImpl> _pageClient;
>     ALLOW_DEPRECATED_DECLARATIONS_BEGIN
>@@ -190,6 +226,7 @@ @implementation WKContentView {
>     WebKit::HistoricalVelocityData _historicalKinematicData;
> 
>     RetainPtr<NSUndoManager> _undoManager;
>+    RetainPtr<WKQuirkyNSUndoManager> _quirkyUndoManager;
> 
>     BOOL _isPrintingToPDF;
>     RetainPtr<CGPDFDocumentRef> _printedDocument;
>@@ -498,9 +535,13 @@ - (void)didZoomToScale:(CGFloat)scale
> 
> - (NSUndoManager *)undoManager
> {
>+    if (self.focusedElementInformation.needsQuirkyUndoManager && self.hasHiddenContentEditable) {
>+        if (!_quirkyUndoManager)
>+            _quirkyUndoManager = adoptNS([[WKQuirkyNSUndoManager alloc] initWithContentView:self]);
>+        return _quirkyUndoManager.get();
>+    }
>     if (!_undoManager)
>         _undoManager = adoptNS([[NSUndoManager alloc] init]);
>-
>     return _undoManager.get();
> }
> 
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
>index 68cfc5b717fe8973278284d1ab9c55d4fb2887f2..cdf1972ab82bd467ed7bde387732177d065dfe7a 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
>@@ -470,6 +470,9 @@ FOR_EACH_PRIVATE_WKCONTENTVIEW_ACTION(DECLARE_WKCONTENTVIEW_ACTION_FOR_WEB_VIEW)
> 
> - (void)willFinishIgnoringCalloutBarFadeAfterPerformingAction;
> 
>+- (BOOL)hasHiddenContentEditable;
>+- (void)generateSyntheticUndoRedo:(BOOL)isUndo;
>+
> // UIWebFormAccessoryDelegate protocol
> - (void)accessoryDone;
> 
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index f302bafc4cc48665fd7b5e6b5e2541f70f709ee8..fa4ac6bb8730e935b18c494c6bdead4580f291bf 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -4482,6 +4482,11 @@ - (void)_handleKeyUIEvent:(::UIEvent *)event
>     [super _handleKeyUIEvent:event];
> }
> 
>+- (void)generateSyntheticUndoRedo:(BOOL)isUndo
>+{
>+    _page->generateSyntheticUndoRedo(isUndo);
>+}
>+
> #if !USE(UIKIT_KEYBOARD_ADDITIONS)
> - (void)handleKeyEvent:(::UIEvent *)event
> {
>@@ -5172,6 +5177,7 @@ - (void)_elementDidBlur
>     BOOL editableChanged = [self setIsEditable:NO];
> 
>     _focusedElementInformation.elementType = WebKit::InputType::None;
>+    _focusedElementInformation.needsQuirkyUndoManager = false;
>     _inputPeripheral = nil;
>     _focusRequiresStrongPasswordAssistance = NO;
> 
>@@ -5736,6 +5742,11 @@ - (BOOL)shouldAllowHidingSelectionCommands
>     return !_ignoreSelectionCommandFadeCount;
> }
> 
>+- (BOOL)hasHiddenContentEditable
>+{
>+    return _suppressSelectionAssistantReasons.contains(WebKit::EditableRootIsTransparentOrFullyClipped);
>+}
>+
> - (BOOL)_shouldSuppressSelectionCommands
> {
>     return !!_suppressSelectionAssistantReasons;
>diff --git a/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm b/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
>index 9030b7b87c337b75e3fcfe5f49adc701249961b6..17ccb027536e8469ab3242bad54441341bf3e9c3 100644
>--- a/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
>+++ b/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
>@@ -1102,6 +1102,14 @@ void WebPageProxy::contentSizeCategoryDidChange(const String& contentSizeCategor
>     process().send(Messages::WebPage::ContentSizeCategoryDidChange(contentSizeCategory), m_pageID);
> }
> 
>+void WebPageProxy::generateSyntheticUndoRedo(bool isUndo)
>+{
>+    if (!hasRunningProcess())
>+        return;
>+
>+    process().send(Messages::WebPage::GenerateSyntheticUndoRedo(isUndo), m_pageID);
>+}
>+
> void WebPageProxy::updateEditorState(const EditorState& editorState)
> {
>     bool couldChangeSecureInputState = m_editorState.isInPasswordField != editorState.isInPasswordField || m_editorState.selectionIsNone;
>diff --git a/Source/WebKit/WebProcess/WebPage/WebPage.h b/Source/WebKit/WebProcess/WebPage/WebPage.h
>index d9d804cbd637991052c8c6d2c1ce229e67d36a98..30f319111b70aef0e4258fa9f765f1d24224daa5 100644
>--- a/Source/WebKit/WebProcess/WebPage/WebPage.h
>+++ b/Source/WebKit/WebProcess/WebPage/WebPage.h
>@@ -1221,6 +1221,7 @@ private:
>     RefPtr<WebCore::Range> rangeForWebSelectionAtPosition(const WebCore::IntPoint&, const WebCore::VisiblePosition&, SelectionFlags&);
>     void getFocusedElementInformation(FocusedElementInformation&);
>     void platformInitializeAccessibility();
>+    void generateSyntheticUndoRedo(bool);
>     void handleSyntheticClick(WebCore::Node& nodeRespondingToClick, const WebCore::FloatPoint& location, OptionSet<WebKit::WebEvent::Modifier>);
>     void completeSyntheticClick(WebCore::Node& nodeRespondingToClick, const WebCore::FloatPoint& location, OptionSet<WebKit::WebEvent::Modifier>, WebCore::SyntheticClickType);
>     void sendTapHighlightForNodeIfNecessary(uint64_t requestID, WebCore::Node*);
>diff --git a/Source/WebKit/WebProcess/WebPage/WebPage.messages.in b/Source/WebKit/WebProcess/WebPage/WebPage.messages.in
>index 0123fd9d4fb4b0a19097677046c4dceed6c980ac..3f325b846662203ae3024f0347c7fc71078210b6 100644
>--- a/Source/WebKit/WebProcess/WebPage/WebPage.messages.in
>+++ b/Source/WebKit/WebProcess/WebPage/WebPage.messages.in
>@@ -113,6 +113,7 @@ messages -> WebPage LegacyReceiver {
>     SetIsShowingInputViewForFocusedElement(bool showingInputView)
>     UpdateSelectionWithDelta(int64_t locationDelta, int64_t lengthDelta) -> () Async
>     RequestDocumentEditingContext(struct WebKit::DocumentEditingContextRequest request) -> (struct WebKit::DocumentEditingContext response) Async
>+    GenerateSyntheticUndoRedo(bool isUndo)
> #endif
> 
>     SetControlledByAutomation(bool controlled)
>diff --git a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>index c2db1f5b30b3c70e1993fe65d63e13581c2f8568..e7657e9ef3b256a557475ec7a9c42820ec0559c8 100644
>--- a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>+++ b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>@@ -419,6 +419,11 @@ bool WebPage::handleEditingKeyboardEvent(KeyboardEvent& event)
>     auto* platformEvent = event.underlyingPlatformEvent();
>     if (!platformEvent)
>         return false;
>+    
>+    // Don't send synthetic events to the UIProcess. They are only
>+    // used for interacting with JavaScript.
>+    if (platformEvent->isSyntheticEvent())
>+        return false;
> 
>     // FIXME: Interpret the event immediately upon receiving it in UI process, without sending to WebProcess first.
>     bool eventWasHandled = false;
>@@ -580,6 +585,39 @@ static bool nodeAlwaysTriggersClick(const Node& targetNode)
>     return AccessibilityObject::isARIAControl(ariaRole) || AccessibilityObject::isARIAInput(ariaRole);
> }
> 
>+void WebPage::generateSyntheticUndoRedo(bool isUndo)
>+{
>+    PlatformKeyboardEvent keyEvent;
>+    auto& frame = m_page->focusController().focusedOrMainFrame();
>+    
>+    OptionSet<PlatformEvent::Modifier> modifiers;
>+    modifiers.add(PlatformEvent::Modifier::MetaKey);
>+    
>+    if (isUndo) {
>+        keyEvent = PlatformKeyboardEvent(PlatformEvent::KeyDown, "z", "z",
>+#if ENABLE(KEYBOARD_KEY_ATTRIBUTE)
>+            "z",
>+#endif
>+#if ENABLE(KEYBOARD_CODE_ATTRIBUTE)
>+            "KeyZ"_s,
>+#endif
>+            @"U+005A", 90, false, false, false, modifiers, WallTime::now());
>+    } else {
>+        keyEvent = PlatformKeyboardEvent(PlatformEvent::KeyDown, "y", "y",
>+#if ENABLE(KEYBOARD_KEY_ATTRIBUTE)
>+            "y",
>+#endif
>+#if ENABLE(KEYBOARD_CODE_ATTRIBUTE)
>+            "KeyY"_s,
>+#endif
>+            @"U+0059", 89, false, false, false, modifiers, WallTime::now());
>+    }
>+    
>+    PlatformKeyboardEvent::setCurrentModifierState(modifiers);
>+    
>+    frame.eventHandler().keyEvent(keyEvent);
>+}
>+
> void WebPage::handleSyntheticClick(Node& nodeRespondingToClick, const WebCore::FloatPoint& location, OptionSet<WebEvent::Modifier> modifiers)
> {
>     if (!nodeRespondingToClick.document().settings().contentChangeObserverEnabled()) {
>@@ -2758,6 +2796,7 @@ void WebPage::getFocusedElementInformation(FocusedElementInformation& informatio
>             information.isAutocorrect = focusedElement.shouldAutocorrect();
>             information.autocapitalizeType = focusedElement.autocapitalizeType();
>             information.inputMode = focusedElement.canonicalInputMode();
>+            information.needsQuirkyUndoManager = focusedElement.document().quirks().shouldEmulateUndoRedoInHiddenEditableAreas();
>         } else {
>             information.isAutocorrect = true;
>             information.autocapitalizeType = AutocapitalizeTypeDefault;

Actions: View | Formatted Diff | Diff

Attachments on bug 197452: 368878 | 368882 | 368987 | 368989 | 369001 | 369040 | 369172 | 369209 | 369214 | 369221 | 369254 | 369322 | 369342 | 369346 | 369356 | 369362 | 369396 | 369400 | 369413 | 369416 | 369440