Attachment 369321 Details for Bug 195997 – Patch for landing

[patch] Patch for landing

bug-195997-20190507131333.patch (text/plain), 1.69 KB, created by youenn fablet on 2019-05-07 13:13:35 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-05-07 13:13:35 PDT

Size: 1.69 KB

patch

obsolete

>Subversion Revision: 245009
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 53c2cb6530207da1e6f03dbace80f82066801fe5..a3e682062a382371583af549a158b7f2a33f409e 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-07  Youenn Fablet  <youenn@apple.com>
>+
>+        Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
>+        https://bugs.webkit.org/show_bug.cgi?id=195997
>+        <rdar://problem/50509884>
>+
>+        Reviewed by Chris Dumez.
>+
>+        Spin test until successful.
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
>+
> 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm
>index 1cb90e038eaf3f592c1afd7a879749b76a7503ee..4cd1b3328ad06f8dffe9534f1d36f286a0417df9 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm
>@@ -1396,7 +1396,8 @@ TEST(ServiceWorkers, ServiceWorkerAndCacheStorageDefaultDirectories)
>     [webView loadRequest:request];
>     TestWebKitAPI::Util::run(&done);
>     done = false;
>-    EXPECT_TRUE([[configuration websiteDataStore] _hasRegisteredServiceWorker]);
>+    while (![[configuration websiteDataStore] _hasRegisteredServiceWorker])
>+        TestWebKitAPI::Util::spinRunLoop(0.1);
> 
>     webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
>     [webView.get().configuration.processPool _registerURLSchemeServiceWorkersCanHandle:@"sw"];

Actions: View | Formatted Diff | Diff

Attachments on bug 195997: 369190 | 369253 | 369321