Attachment 369285 Details for Bug 197659 – patch

[patch] patch

overflow-hidden-keyboard-3.patch (text/plain), 3.94 KB, created by Antti Koivisto on 2019-05-07 08:41:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antti Koivisto

Created: 2019-05-07 08:41:01 PDT

Size: 3.94 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 245009)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-05-07  Antti Koivisto  <antti@apple.com>
>+
>+        <body> with overflow:hidden shouldn't be keyboard scrollable on iOS
>+        https://bugs.webkit.org/show_bug.cgi?id=197659
>+        <rdar://problem/50541453>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView isScrollableForKeyboardScrollViewAnimator:]):
>+
>+        Disable also keyboard scrolling when touch scrolling is disabled.
>+
> 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
>Index: Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>===================================================================
>--- Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	(revision 245007)
>+++ Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	(working copy)
>@@ -4620,6 +4620,9 @@ - (BOOL)isScrollableForKeyboardScrollVie
>     if (_focusedElementInformation.elementType == WebKit::InputType::Select)
>         return NO;
> 
>+    if (!_webView.scrollView.scrollEnabled)
>+        return NO;
>+
>     return YES;
> }
> 
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 245007)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-05-07  Antti Koivisto  <antti@apple.com>
>+
>+        <body> with overflow:hidden shouldn't be keyboard scrollable on iOS
>+        https://bugs.webkit.org/show_bug.cgi?id=197659
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * fast/scrolling/ios/body-overflow-hidden-keyboard-expected.html: Added.
>+        * fast/scrolling/ios/body-overflow-hidden-keyboard.html: Added.
>+
> 2019-05-07  Antti Koivisto  <antti@apple.com>
> 
>         <body> with overflow:hidden CSS is scrollable on iOS
>Index: LayoutTests/fast/scrolling/ios/body-overflow-hidden-keyboard-expected.html
>===================================================================
>--- LayoutTests/fast/scrolling/ios/body-overflow-hidden-keyboard-expected.html	(nonexistent)
>+++ LayoutTests/fast/scrolling/ios/body-overflow-hidden-keyboard-expected.html	(working copy)
>@@ -0,0 +1,13 @@
>+<!DOCTYPE html> 
>+<head>
>+<meta name="viewport" content="width=device-width, initial-scale=1">
>+<style>
>+body { overflow: hidden }
>+.scroll-content { width: 500px; height: 5000px; border: 2px solid green; }
>+</style>
>+<body>
>+<div class="scroll-content">
>+This document shouldn't be scrollable.
>+</div>
>+</body>
>+</html>
>Index: LayoutTests/fast/scrolling/ios/body-overflow-hidden-keyboard.html
>===================================================================
>--- LayoutTests/fast/scrolling/ios/body-overflow-hidden-keyboard.html	(nonexistent)
>+++ LayoutTests/fast/scrolling/ios/body-overflow-hidden-keyboard.html	(working copy)
>@@ -0,0 +1,33 @@
>+<!DOCTYPE html> 
>+<head>
>+<meta name="viewport" content="width=device-width, initial-scale=1">
>+<script src="../../../resources/ui-helper.js"></script>
>+<style>
>+body { overflow: hidden }
>+.scroll-content { width: 500px; height: 5000px; border: 2px solid green; }
>+</style>
>+<script>
>+if (window.testRunner)
>+    testRunner.waitUntilDone();
>+
>+function waitPromise(delay)
>+{
>+    return new Promise(resolve => setTimeout(resolve, delay));
>+}
>+
>+async function runTest() {
>+    if (!window.testRunner)
>+        return;
>+
>+    await UIHelper.typeCharacter("downArrow");
>+    await waitPromise(50);
>+
>+    testRunner.notifyDone();
>+}
>+</script>
>+<body onload="runTest()">
>+<div class="scroll-content">
>+This document shouldn't be scrollable.
>+</div>
>+</body>
>+</html>

Actions: View | Formatted Diff | Diff

Attachments on bug 197659: 369279 | 369284 | 369285