Attachment 369229 Details for Bug 197646 – Patch

[patch] Patch

bug-197646-20190506214634.patch (text/plain), 5.36 KB, created by Eric Liang on 2019-05-06 21:46:35 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Liang

Created: 2019-05-06 21:46:35 PDT

Size: 5.36 KB

patch

obsolete

>Subversion Revision: 244997
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 42e5e3d80df73bdc392da6827deccf409ecf08d3..795d1f83f4843dd1f566ba9e04e5d00e61a07774 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-06  Eric Liang  <ericliang@apple.com>
>+
>+        Size for accessibility links should not query hierarchy below the link because its ring should bound to itself. 
>+        https://bugs.webkit.org/show_bug.cgi?id=197646
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Tests updated
>+
>+        * accessibility/AccessibilityRenderObject.cpp:
>+        (WebCore::AccessibilityRenderObject::boundingBoxRect const):
>+
> 2019-05-06  Chris Dumez  <cdumez@apple.com>
> 
>         Add assertions to JSLazyEventListener to help catch the cause of a crash
>diff --git a/Source/WebCore/accessibility/AccessibilityRenderObject.cpp b/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
>index de2a0052b8345088f4cc1c7b572382b19f847a4c..374b9b11a5a130b6aef6283c43d3ae22519f2f71 100644
>--- a/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
>+++ b/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
>@@ -836,7 +836,7 @@ LayoutRect AccessibilityRenderObject::boundingBoxRect() const
> 
>     if (is<RenderText>(*obj))
>         quads = downcast<RenderText>(*obj).absoluteQuadsClippedToEllipsis();
>-    else if (isWebArea() || isSVGRoot)
>+    else if (isWebArea() || isSVGRoot || isLink())
>         obj->absoluteQuads(quads);
>     else
>         obj->absoluteFocusRingQuads(quads);
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 1648c6b0259af7c4d2a1b76cf7508da804478137..7d7b036ccdc63e41bf948fbaf730b50e2a57051f 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-05-06  Eric Liang  <ericliang@apple.com>
>+
>+        Size for accessibility links should not query hierarchy below the link because its ring should bound to itself.
>+        https://bugs.webkit.org/show_bug.cgi?id=197646
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * accessibility/dimensions-include-descendants-expected.txt:
>+        * accessibility/image-link-expected.txt:
>+        * accessibility/mac/document-links-expected.txt:
>+        * accessibility/mac/relative-frame-expected.txt:
>+        * platform/mac/accessibility/form-control-value-settable-expected.txt:
>+
> 2019-05-06  Andres Gonzalez  <andresg_22@apple.com>
> 
>         Hitpoint for link which spans two lines in web content is incorrect
>diff --git a/LayoutTests/accessibility/dimensions-include-descendants-expected.txt b/LayoutTests/accessibility/dimensions-include-descendants-expected.txt
>index 5af72d21247114c91d6b0dd8de920bfbb206fc05..7fe90ca654683b6b0350ca5a63690bb8a49a0bda 100644
>--- a/LayoutTests/accessibility/dimensions-include-descendants-expected.txt
>+++ b/LayoutTests/accessibility/dimensions-include-descendants-expected.txt
>@@ -1 +1 @@
>-link 1 dimensions: 100 x 100; link 2 dimensions: 100 x 100
>+link 1 dimensions: 20 x 18; link 2 dimensions: 100 x 18
>diff --git a/LayoutTests/accessibility/image-link-expected.txt b/LayoutTests/accessibility/image-link-expected.txt
>index e548697f7cf698c9754999e1195adbd788e86b52..d191ed8483a62377b0576504878e1baac1256ff3 100644
>--- a/LayoutTests/accessibility/image-link-expected.txt
>+++ b/LayoutTests/accessibility/image-link-expected.txt
>@@ -9,7 +9,7 @@ AXRoleDescription: link
> AXChildren: <array of size 1>
> AXHelp: 
> AXParent: <AXLink: 'Delicious cake'>
>-AXSize: NSSize: {280, 215}
>+AXSize: NSSize: {280, 19}
> AXTitle: Delicious cake
> AXDescription: 
> AXValue: 
>diff --git a/LayoutTests/accessibility/mac/document-links-expected.txt b/LayoutTests/accessibility/mac/document-links-expected.txt
>index bc9b5d6dad41341ddd88c39c2d7b610a90efa042..56175cd1238eee7570404b6723299ed620aaaca3 100644
>--- a/LayoutTests/accessibility/mac/document-links-expected.txt
>+++ b/LayoutTests/accessibility/mac/document-links-expected.txt
>@@ -107,7 +107,7 @@ AXRoleDescription: link
> AXChildren: <array of size 1>
> AXHelp: 
> AXParent: <AXLink: 'link 4'>
>-AXSize: NSSize: {37, 18}
>+AXSize: NSSize: {38, 18}
> AXTitle: link 4
> AXDescription: 
> AXValue: 
>diff --git a/LayoutTests/accessibility/mac/relative-frame-expected.txt b/LayoutTests/accessibility/mac/relative-frame-expected.txt
>index cfa2602cf1ae972780617691a4f63f9f2aa8aaed..a3e787a8489c0d37bdff219c4047923fab5e61f6 100644
>--- a/LayoutTests/accessibility/mac/relative-frame-expected.txt
>+++ b/LayoutTests/accessibility/mac/relative-frame-expected.txt
>@@ -4,7 +4,7 @@ This tests the relative frame attribute returns accurate data.
> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
> 
> 
>-relative frame: NSRect: {{8, 8}, {90, 18}}
>+relative frame: NSRect: {{8, 8}, {91, 18}}
> PASS successfullyParsed is true
> 
> TEST COMPLETE
>diff --git a/LayoutTests/platform/mac/accessibility/form-control-value-settable-expected.txt b/LayoutTests/platform/mac/accessibility/form-control-value-settable-expected.txt
>index f633269df9536ce422a9077815664c1d2bdf02a2..9946138e2433068410d5c2d85245782b57b9e7b5 100644
>--- a/LayoutTests/platform/mac/accessibility/form-control-value-settable-expected.txt
>+++ b/LayoutTests/platform/mac/accessibility/form-control-value-settable-expected.txt
>@@ -1,5 +1,5 @@
>-               
>-               
>+                
>+                
> This tests whether AXValue is writable for various form controls.
> 
> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

Flags:

rniwa: review-
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 197646: 369229 | 369237 | 369240 | 369242