Attachment 369189 Details for Bug 197632 – Just to see...

[patch] Just to see...

Hack_050619.patch (text/plain), 1.90 KB, created by Daniel Bates on 2019-05-06 15:55:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2019-05-06 15:55:59 PDT

Size: 1.90 KB

patch

obsolete

>From 92f61e594584c6de61bd4a4f2b444d5cadcbf6b8 Mon Sep 17 00:00:00 2001
>From: Daniel Bates <dabates@apple.com>
>Date: Mon, 6 May 2019 15:33:40 -0700
>Subject: [PATCH] Just for laughs fix for <rdar://problem/47902054>.
>
>---
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm | 2 +-
> Source/WebKitLegacy/mac/WebView/WebHTMLView.mm          | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index b12368b826b..6fec1dd7285 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -4574,7 +4574,7 @@ - (BOOL)_interpretKeyEvent:(::WebEvent *)event isCharEvent:(BOOL)isCharEvent
>         if (contentEditable && isCharEvent) {
>             // Map \r from HW keyboard to \n to match the behavior of the soft keyboard.
>             [keyboard addInputString:@"\n" withFlags:0 withInputManagerHint:nil];
>-            return YES;
>+            return NO; // Let WebCore handle the Return or Enter key, which may trigger form submission.
>         }
>         break;
>     default:
>diff --git a/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm b/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
>index 6b048a1642e..942e6d1a145 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
>+++ b/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
>@@ -6109,7 +6109,7 @@ - (BOOL)_handleEditingKeyEvent:(KeyboardEvent *)wcEvent
>             if (isCharEvent) {
>                 // Map \r from HW keyboard to \n to match the behavior of the soft keyboard.
>                 [[webView _UIKitDelegateForwarder] addInputString:@"\n" withFlags:0];
>-                return YES;
>+                return NO; // Let WebCore handle the Return or Enter key, which may trigger form submission.
>             }
>             break;
>         default:
>-- 
>2.20.1 (Apple Git-117)
>

Actions: View | Formatted Diff | Diff

Attachments on bug 197632: 369189 | 369277 | 369428 | 369441 | 369446 | 369464 | 369497