Attachment 369028 Details for Bug 197587 – Patch

[patch] Patch

bug-197587-20190503171718.patch (text/plain), 1.27 KB, created by Yusuke Suzuki on 2019-05-03 17:17:18 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2019-05-03 17:17:18 PDT

Size: 1.27 KB

patch

obsolete

>Subversion Revision: 244939
>diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog
>index 52420d8cef82a38cb140eceb1d7f8c1dd8371b8b..c352114390730814416ef74c4bdc7466d7aeac1b 100644
>--- a/JSTests/ChangeLog
>+++ b/JSTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
>+
>+        [JSC] Add more tests for DFG SetLocal emission for adhoc SetterCall frame
>+        https://bugs.webkit.org/show_bug.cgi?id=197587
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch adds more tests to r244939. It also inlines setter calls, and eventually see that no PutStack is emitted because MovHint's KillStack kills it.
>+
>+        * stress/adhoc-setter-frame-should-not-be-killed.js: Added.
>+
> 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
> 
>         [JSC] Need to emit SetLocal if we emit MovHint in DFGByteCodeParser
>diff --git a/JSTests/stress/adhoc-setter-frame-should-not-be-killed.js b/JSTests/stress/adhoc-setter-frame-should-not-be-killed.js
>new file mode 100644
>index 0000000000000000000000000000000000000000..86a7ccb90b4e2f14c82027c54a129e9754872f5c
>--- /dev/null
>+++ b/JSTests/stress/adhoc-setter-frame-should-not-be-killed.js
>@@ -0,0 +1,7 @@
>+let o = {};
>+o.__defineSetter__('f', function(a) {
>+    arguments = a;
>+});
>+for (let i = 0; i<1000000; i++) {
>+    o.f = 0
>+}

Flags:

sam: review+
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 197587: 369028 | 369065