Attachment 368994 Details for Bug 197496 – Patch

[patch] Patch

bug-197496-20190503144222.patch (text/plain), 2.15 KB, created by Aakash Jain on 2019-05-03 14:42:23 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-05-03 14:42:23 PDT

Size: 2.15 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 244921)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-05-03  Aakash Jain  <aakash_jain@apple.com>
>+
>+        New EWS: patches on recently added queues listed as #1 for older bugs
>+        https://bugs.webkit.org/show_bug.cgi?id=197496
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
>+        (StatusBubble._build_bubble):
>+        (StatusBubble._queue_position):
>+
> 2019-05-03  Chris Dumez  <cdumez@apple.com>
> 
>         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
>Index: Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py	(revision 244892)
>+++ Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py	(working copy)
>@@ -62,6 +62,8 @@ class StatusBubble(View):
>             bubble['state'] = 'none'
>             queue_position = self._queue_position(patch, queue, self._get_parent_queue(queue))
>             bubble['queue_position'] = queue_position
>+            if not queue_position:
>+                return None
>             bubble['details_message'] = 'Waiting in queue, processing has not started yet.\n\nPosition in queue: {}'.format(queue_position)
>             return bubble
> 
>@@ -181,6 +183,12 @@ class StatusBubble(View):
>         DAYS_TO_CHECK = 3
>         from_timestamp = timezone.now() - datetime.timedelta(days=DAYS_TO_CHECK)
> 
>+        if patch.modified < from_timestamp:
>+            # Do not display bubble for old patch for which no build has been reported on given queue.
>+            # Most likely the patch would never be processed on this queue, since eiter queue was added
>+            # after the patch was submitted, or build request for that patch was cancelled.
>+            return None
>+
>         previously_sent_patches = set(Patch.objects
>                                           .filter(modified__gte=from_timestamp)
>                                           .filter(sent_to_buildbot=True)

Flags:

lforschler: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 197496: 368769 | 368770 | 368771 | 368994