WebKit Bugzilla
Attachment 368944 Details for
Bug 136627
: WebVTT: vertical cue text alignment is the wrong way around
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Address post review comments
bug-136627-20190503101134.patch (text/plain), 1.89 KB, created by
Eric Carlson
on 2019-05-03 10:11:35 PDT
(
hide
)
Description:
Address post review comments
Filename:
MIME Type:
Creator:
Eric Carlson
Created:
2019-05-03 10:11:35 PDT
Size:
1.89 KB
patch
obsolete
>Subversion Revision: 244907 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 586dc3eb7fdb555a46f3c3c4692e0d92409d9c90..8b4ff6b40acdf5194af416dad3b19f49aee53aeb 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,16 @@ >+2019-05-03 Eric Carlson <eric.carlson@apple.com> >+ >+ WebVTT: vertical cue text alignment is the wrong way around >+ https://bugs.webkit.org/show_bug.cgi?id=136627 >+ <rdar://problem/49725538> >+ >+ Address post review comments. >+ >+ * html/track/VTTCue.cpp: >+ (WebCore::VTTCueBox::applyCSSProperties): FormattedNumber is not necessary, use >+ videoSize.width() and cue->getCSSSize() directly as that gets "shortest" floating >+ point formatting and avoids unnecessary rounding. >+ > 2019-05-03 Commit Queue <commit-queue@webkit.org> > > Unreviewed, rolling out r244881. >diff --git a/Source/WebCore/html/track/VTTCue.cpp b/Source/WebCore/html/track/VTTCue.cpp >index 10d5cc0625a906ee58a5192582261b0ce11f1297..21b84c1fb7a5eca43d7aad82dbc49619c5e4f52a 100644 >--- a/Source/WebCore/html/track/VTTCue.cpp >+++ b/Source/WebCore/html/track/VTTCue.cpp >@@ -181,7 +181,7 @@ void VTTCueBox::applyCSSProperties(const IntSize& videoSize) > if (cue->vertical() == horizontalKeyword()) > setInlineStyleProperty(CSSPropertyLeft, position.first, CSSPrimitiveValue::CSS_PERCENTAGE); > else if (cue->vertical() == verticalGrowingRightKeyword()) >- setInlineStyleProperty(CSSPropertyLeft, makeString("calc(-", FormattedNumber::fixedWidth(videoSize.width(), 2), "px - ", FormattedNumber::fixedWidth(cue->getCSSSize(), 2), "px)")); >+ setInlineStyleProperty(CSSPropertyLeft, makeString("calc(-", videoSize.width(), "px - ", cue->getCSSSize(), "px)")); > > double authorFontSize = std::min(videoSize.width(), videoSize.height()) * DEFAULTCAPTIONFONTSIZEPERCENTAGE / 100.0; > double multiplier = 1.0;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
commit-queue
:
commit-queue-
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 136627
:
368261
|
368294
|
368784
|
368789
|
368792
|
368802
|
368808
|
368811
|
368944
|
368947