Attachment 362814 Details for Bug 194974 – Fix attempt

[patch] Fix attempt

fix194974.patch (text/plain), 1.82 KB, created by Ryosuke Niwa on 2019-02-22 20:09:10 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2019-02-22 20:09:10 PST

Size: 1.82 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 241979)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,20 @@
>+2019-02-22  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        Crash in SWServerJobQueue::runNextJobSynchronously
>+        https://bugs.webkit.org/show_bug.cgi?id=194974
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We suspect the crash is happening due to m_jobQueue being empty in runNextJobSynchronously
>+        or there is a timer heap corruption again :(
>+
>+        Exit early when m_jobQueue is empty. Also add a debug assert that this should never happen
>+        but convert an existing release assert to a debug assert since this appears to be hitting
>+        too frequently in wild.
>+
>+        * workers/service/server/SWServerJobQueue.cpp:
>+        (WebCore::SWServerJobQueue::runNextJobSynchronously):
>+
> 2019-02-22  Tim Horton  <timothy_horton@apple.com>
> 
>         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
>Index: Source/WebCore/workers/service/server/SWServerJobQueue.cpp
>===================================================================
>--- Source/WebCore/workers/service/server/SWServerJobQueue.cpp	(revision 241928)
>+++ Source/WebCore/workers/service/server/SWServerJobQueue.cpp	(working copy)
>@@ -234,6 +234,10 @@ void SWServerJobQueue::runNextJob()
> 
> void SWServerJobQueue::runNextJobSynchronously()
> {
>+    ASSERT(!m_jobQueue.isEmpty());
>+    if (m_jobQueue.isEmpty())
>+        return;
>+
>     auto& job = firstJob();
>     switch (job.type) {
>     case ServiceWorkerJobType::Register:
>@@ -247,7 +251,7 @@ void SWServerJobQueue::runNextJobSynchro
>         return;
>     }
> 
>-    RELEASE_ASSERT_NOT_REACHED();
>+    ASSERT_NOT_REACHED();
> }
> 
> // https://w3c.github.io/ServiceWorker/#register-algorithm

Actions: View | Formatted Diff | Diff

Attachments on bug 194974: 362814