Attachment 362795 Details for Bug 194971 – Patch

[patch] Patch

bug-194971-20190222170138.patch (text/plain), 1.67 KB, created by Andy Estes on 2019-02-22 17:01:38 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Andy Estes

Created: 2019-02-22 17:01:38 PST

Size: 1.67 KB

patch

obsolete

>Subversion Revision: 241970
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 1a32eee4cd41761322bddfa80c01e75210319397..d726c708b246297cf263808464293df44f472e09 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-02-22  Andy Estes  <aestes@apple.com>
>+
>+        [Cocoa] Do not suppress deprecation warnings when calling sandbox_extension_issue_file
>+        https://bugs.webkit.org/show_bug.cgi?id=194971
>+        <rdar://problem/35786264>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        sandbox_extension_issue_file is not actually deprecated.
>+
>+        * Shared/mac/SandboxExtensionMac.mm:
>+        (WebKit::SandboxExtensionImpl::sandboxExtensionForType):
>+
> 2019-02-22  Simon Fraser  <simon.fraser@apple.com>
> 
>         Unreviewed build fix: need a WebCore:: namespace on ScrollingEventResult.
>diff --git a/Source/WebKit/Shared/mac/SandboxExtensionMac.mm b/Source/WebKit/Shared/mac/SandboxExtensionMac.mm
>index afbc6b2a14e5bff0c16656b7c20877cbcddd4571..1f7b9619087b623858d1713fc59e9a630bb889eb 100644
>--- a/Source/WebKit/Shared/mac/SandboxExtensionMac.mm
>+++ b/Source/WebKit/Shared/mac/SandboxExtensionMac.mm
>@@ -84,11 +84,9 @@ private:
>     {
>         switch (type) {
>         case SandboxExtension::Type::ReadOnly:
>-            ALLOW_DEPRECATED_DECLARATIONS_BEGIN
>             return sandbox_extension_issue_file(APP_SANDBOX_READ, path, 0);
>         case SandboxExtension::Type::ReadWrite:
>             return sandbox_extension_issue_file(APP_SANDBOX_READ_WRITE, path, 0);
>-            ALLOW_DEPRECATED_DECLARATIONS_END
>         case SandboxExtension::Type::Generic:
>             return sandbox_extension_issue_generic(path, 0);
>         }

Actions: View | Formatted Diff | Diff

Attachments on bug 194971: 362795