WebKit Bugzilla
Attachment 362781 Details for
Bug 194747
: [MSE] SourceBuffer sample time increment vs. last frame duration check is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch Rev2
source-buffer-cpp-rev2.patch (text/plain), 1.36 KB, created by
up
on 2019-02-22 16:20:22 PST
(
hide
)
Description:
Patch Rev2
Filename:
MIME Type:
Creator:
up
Created:
2019-02-22 16:20:22 PST
Size:
1.36 KB
patch
obsolete
>Index: Source/WebCore/Modules/mediasource/SourceBuffer.cpp >=================================================================== >--- Source/WebCore/Modules/mediasource/SourceBuffer.cpp (revision 241947) >+++ Source/WebCore/Modules/mediasource/SourceBuffer.cpp (working copy) >@@ -1547,8 +1547,14 @@ void SourceBuffer::sourceBufferPrivateDidReceiveSample(MediaSample& sample) > // OR > // â³ If last decode timestamp for track buffer is set and the difference between decode timestamp and > // last decode timestamp is greater than 2 times last frame duration: >+ MediaTime decodeDurationToCheck = trackBuffer.greatestDecodeDuration; >+ >+ if (decodeDurationToCheck.isValid() && trackBuffer.lastFrameDuration.isValid() >+ && (trackBuffer.lastFrameDuration > decodeDurationToCheck)) >+ decodeDurationToCheck = trackBuffer.lastFrameDuration; >+ > if (trackBuffer.lastDecodeTimestamp.isValid() && (decodeTimestamp < trackBuffer.lastDecodeTimestamp >- || (trackBuffer.greatestDecodeDuration.isValid() && abs(decodeTimestamp - trackBuffer.lastDecodeTimestamp) > (trackBuffer.greatestDecodeDuration * 2)))) { >+ || (decodeDurationToCheck.isValid() && abs(decodeTimestamp - trackBuffer.lastDecodeTimestamp) > (decodeDurationToCheck * 2)))) { > > // 1.6.1: > if (m_mode == AppendMode::Segments) {
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194747
:
362395
|
362396
|
362398
|
362766
| 362781 |
363004