Attachment 362779 Details for Bug 194966 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

dark-1.patch (text/plain), 1.85 KB, created by Joseph Pecoraro on 2019-02-22 16:20:05 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-02-22 16:20:05 PST

Size: 1.85 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 85b0d848739..d9d1d29de90 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-02-22  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Dark Mode: Network Overview Graph segments have distracting white box shadow
>+        https://bugs.webkit.org/show_bug.cgi?id=194966
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/NetworkTimelineOverviewGraph.css:
>+        (@media (prefers-color-scheme: dark)):
>+        (.timeline-overview-graph.network > .graph-row > .timeline-record-bar > .segment:not(.inactive)):
>+        (.timeline-overview-graph.network:nth-child(even) > .graph-row > .timeline-record-bar > .segment:not(.inactive)):
>+        Provide dark mode box shadow colors.
>+
> 2019-02-21  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: Remove unused Timeline record selection code path
>diff --git a/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineOverviewGraph.css b/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineOverviewGraph.css
>index 07332fa04ee..b9db0f5065e 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineOverviewGraph.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineOverviewGraph.css
>@@ -43,3 +43,13 @@
> .timeline-overview-graph.network:nth-child(even) > .graph-row > .timeline-record-bar > .segment:not(.inactive) {
>     box-shadow: hsl(0, 0%, 96%) 1px 0 0;
> }
>+
>+@media (prefers-color-scheme: dark) {
>+    .timeline-overview-graph.network > .graph-row > .timeline-record-bar > .segment:not(.inactive) {
>+        box-shadow: hsl(0, 0%, 21%) 1px 0 0;
>+    }
>+
>+    .timeline-overview-graph.network:nth-child(even) > .graph-row > .timeline-record-bar > .segment:not(.inactive) {
>+        box-shadow: hsl(0, 0%, 25%) 1px 0 0;
>+    }
>+}

Actions: View | Formatted Diff | Diff

Attachments on bug 194966: 362779 | 362780 | 362782 | 362787 | 362788 | 362811