Attachment 362776 Details for Bug 194964 – Patch

[patch] Patch

bug-194964-20190222160427.patch (text/plain), 1.66 KB, created by Andy Estes on 2019-02-22 16:04:27 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Andy Estes

Created: 2019-02-22 16:04:27 PST

Size: 1.66 KB

patch

obsolete

>Subversion Revision: 241963
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 8e793d00f733f8073f2e44115fdb41270b0b65c5..b2ea0735337620e0c99897189fa6249aac2ee77b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-02-22  Andy Estes  <aestes@apple.com>
>+
>+        [iOS] Break a reference cycle between PreviewLoader and ResourceLoader
>+        https://bugs.webkit.org/show_bug.cgi?id=194964
>+        <rdar://problem/48279441>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When a document's QuickLook preview is loaded, a reference cycle is created between
>+        PreviewLoader and ResourceLoader. Break the cycle by clearing m_previewLoader in
>+        ResourceLoader::releaseResources().
>+
>+        Fixes leaks detected by `run-webkit-tests --leaks LayoutTests/quicklook`.
>+
>+        * loader/ResourceLoader.cpp:
>+        (WebCore::ResourceLoader::releaseResources):
>+
> 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         Input type "formatSetInlineTextDirection" is dispatched when changing paragraph-level text direction
>diff --git a/Source/WebCore/loader/ResourceLoader.cpp b/Source/WebCore/loader/ResourceLoader.cpp
>index 6c2b131cb9a8d26347a0a7c8e5985419e36c5933..6b26437d863046ed7742686b4e74b890e80cc503 100644
>--- a/Source/WebCore/loader/ResourceLoader.cpp
>+++ b/Source/WebCore/loader/ResourceLoader.cpp
>@@ -113,6 +113,10 @@ void ResourceLoader::releaseResources()
> 
>     m_resourceData = nullptr;
>     m_deferredRequest = ResourceRequest();
>+
>+#if USE(QUICK_LOOK)
>+    m_previewLoader = nullptr;
>+#endif
> }
> 
> void ResourceLoader::init(ResourceRequest&& clientRequest, CompletionHandler<void(bool)>&& completionHandler)

Actions: View | Formatted Diff | Diff

Attachments on bug 194964: 362776 | 365902