Attachment 362741 Details for Bug 194824 – Patch

[patch] Patch

bug-194824-20190222121203.patch (text/plain), 5.96 KB, created by Keith Miller on 2019-02-22 12:12:03 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Miller

Created: 2019-02-22 12:12:03 PST

Size: 5.96 KB

patch

obsolete

>Subversion Revision: 241761
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index bd85c4e3977af05eeec4948caa2339531852f944..c901817b9fd58e704d69f25135b2043f52ecfa3f 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-02-22  Keith Miller  <keith_miller@apple.com>
>+
>+        Code quality cleanup in NeverDestroyed
>+        https://bugs.webkit.org/show_bug.cgi?id=194824
>+
>+        Reviewed by Yusuke Suzuki.
>+
>+        First, move data members to the end of the class per WebKit
>+        style. Also, add forbid heap allocation since we expect the
>+        NeverDestroyed classes to be static.
>+
>+        * wtf/NeverDestroyed.h:
>+
> 2019-02-16  Darin Adler  <darin@apple.com>
> 
>         Continue reducing use of String::format, now focusing on hex: "%p", "%x", etc.
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index a6da53fe8e04ad79dd06c117c410a040b2b97e76..c1dbf77cdfdf7a01e8289d9c1d5119847cd8b4d8 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-02-22  Keith Miller  <keith_miller@apple.com>
>+
>+        Code quality cleanup in NeverDestroyed
>+        https://bugs.webkit.org/show_bug.cgi?id=194824
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        name_names.pl should not just assume the layout of LazyNeverDestroyed.
>+
>+        * dom/make_names.pl:
>+        (printNamesCppFile):
>+
> 2019-02-19  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r241722.
>diff --git a/Source/WTF/wtf/NeverDestroyed.h b/Source/WTF/wtf/NeverDestroyed.h
>index c311f136ff5e5840ee5f49ee5f718686187d64c7..e7e8a7ea03989cba404eabb8253500d5c3f7f553 100644
>--- a/Source/WTF/wtf/NeverDestroyed.h
>+++ b/Source/WTF/wtf/NeverDestroyed.h
>@@ -27,6 +27,7 @@
> 
> #include <type_traits>
> #include <utility>
>+#include <wtf/ForbidHeapAllocation.h>
> #include <wtf/RefCounted.h>
> 
> // NeverDestroyed is a smart-pointer-like class that ensures that the destructor
>@@ -43,8 +44,9 @@ namespace WTF {
> 
> template<typename T> class NeverDestroyed {
>     WTF_MAKE_NONCOPYABLE(NeverDestroyed);
>-
>+    WTF_FORBID_HEAP_ALLOCATION;
> public:
>+
>     template<typename... Args> NeverDestroyed(Args&&... args)
>     {
>         MaybeRelax<T>(new (storagePointer()) T(std::forward<Args>(args)...));
>@@ -66,16 +68,16 @@ private:
> 
>     PointerType storagePointer() const { return const_cast<PointerType>(reinterpret_cast<const T*>(&m_storage)); }
> 
>-    // FIXME: Investigate whether we should allocate a hunk of virtual memory
>-    // and hand out chunks of it to NeverDestroyed instead, to reduce fragmentation.
>-    typename std::aligned_storage<sizeof(T), std::alignment_of<T>::value>::type m_storage;
>-
>     template<typename PtrType, bool ShouldRelax = std::is_base_of<RefCountedBase, PtrType>::value> struct MaybeRelax {
>         explicit MaybeRelax(PtrType*) { }
>     };
>     template<typename PtrType> struct MaybeRelax<PtrType, true> {
>         explicit MaybeRelax(PtrType* ptr) { ptr->relaxAdoptionRequirement(); }
>     };
>+
>+    // FIXME: Investigate whether we should allocate a hunk of virtual memory
>+    // and hand out chunks of it to NeverDestroyed instead, to reduce fragmentation.
>+    typename std::aligned_storage<sizeof(T), std::alignment_of<T>::value>::type m_storage;
> };
> 
> template<typename T> NeverDestroyed<T> makeNeverDestroyed(T&&);
>@@ -85,7 +87,7 @@ template<typename T> NeverDestroyed<T> makeNeverDestroyed(T&&);
> // share more of the code with the main NeverDestroyed above.
> template<typename T> class LazyNeverDestroyed {
>     WTF_MAKE_NONCOPYABLE(LazyNeverDestroyed);
>-
>+    WTF_FORBID_HEAP_ALLOCATION;
> public:
>     LazyNeverDestroyed() = default;
> 
>@@ -124,10 +126,6 @@ private:
>         return const_cast<PointerType>(reinterpret_cast<const T*>(&m_storage));
>     }
> 
>-    // FIXME: Investigate whether we should allocate a hunk of virtual memory
>-    // and hand out chunks of it to NeverDestroyed instead, to reduce fragmentation.
>-    typename std::aligned_storage<sizeof(T), std::alignment_of<T>::value>::type m_storage;
>-
>     template<typename PtrType, bool ShouldRelax = std::is_base_of<RefCountedBase, PtrType>::value> struct MaybeRelax {
>         explicit MaybeRelax(PtrType*) { }
>     };
>@@ -140,6 +138,10 @@ private:
>     // It must not be initialized dynamically; that would not be thread safe.
>     bool m_isConstructed;
> #endif
>+
>+    // FIXME: Investigate whether we should allocate a hunk of virtual memory
>+    // and hand out chunks of it to NeverDestroyed instead, to reduce fragmentation.
>+    typename std::aligned_storage<sizeof(T), std::alignment_of<T>::value>::type m_storage;
> };
> 
> template<typename T> inline NeverDestroyed<T> makeNeverDestroyed(T&& argument)
>diff --git a/Source/WebCore/dom/make_names.pl b/Source/WebCore/dom/make_names.pl
>index b1e76cfda1fa87fe999efde6244b6d37b800c20a..3bae491d72bebd533197473a387c1d650665aa65 100755
>--- a/Source/WebCore/dom/make_names.pl
>+++ b/Source/WebCore/dom/make_names.pl
>@@ -773,7 +773,7 @@ sub printNamesCppFile
>         print F "\n\nconst WebCore::$parameters{namespace}QualifiedName* const* get$parameters{namespace}Tags()\n";
>         print F "{\n    static const WebCore::$parameters{namespace}QualifiedName* const $parameters{namespace}Tags[] = {\n";
>         for my $name (sort keys %allTags) {
>-            print F "        reinterpret_cast<const WebCore::$parameters{namespace}QualifiedName*>(&${name}Tag),\n";
>+            print F "        &${name}Tag.get(),\n";
>         }
>         print F "    };\n";
>         print F "    return $parameters{namespace}Tags;\n";
>@@ -788,7 +788,7 @@ sub printNamesCppFile
>         print F "\n\nconst WebCore::QualifiedName* const* get$parameters{namespace}Attrs()\n";
>         print F "{\n    static const WebCore::QualifiedName* const $parameters{namespace}Attrs[] = {\n";
>         for my $name (sort keys %allAttrs) {
>-            print F "        reinterpret_cast<const WebCore::QualifiedName*>(&${name}Attr),\n";
>+            print F "        &${name}Attr.get(),\n";
>         }
>         print F "    };\n";
>         print F "    return $parameters{namespace}Attrs;\n";

Actions: View | Formatted Diff | Diff

Attachments on bug 194824: 362406 | 362409 | 362410 | 362740 | 362741