Attachment 362724 Details for Bug 194917 – Patch

[patch] Patch

bug-194917-20190222085754.patch (text/plain), 2.65 KB, created by Jonathan Bedard on 2019-02-22 08:57:54 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2019-02-22 08:57:54 PST

Size: 2.65 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 241924)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-02-21  Jonathan Bedard  <jbedard@apple.com>
>+
>+        build-dumprendertree, build-webkittestrunner: Build WebCore test support libraries
>+        https://bugs.webkit.org/show_bug.cgi?id=194917
>+        <rdar://problem/48278600>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/build-dumprendertree: Build WebCoreTestSupport and WebCoreTestShim.
>+        * Scripts/build-webkittestrunner: Ditto.
>+
> 2019-02-21  David Kilzer  <ddkilzer@apple.com>
> 
>         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
>Index: Tools/Scripts/build-dumprendertree
>===================================================================
>--- Tools/Scripts/build-dumprendertree	(revision 241924)
>+++ Tools/Scripts/build-dumprendertree	(working copy)
>@@ -61,11 +61,11 @@ setConfiguration();
> chdirWebKit();
> 
> # Build
>-chdir File::Spec->catdir("Tools", "DumpRenderTree") or die;
>-
> my $result;
> if (isAppleCocoaWebKit()) {
>-    $result = buildXCodeProject("DumpRenderTree", $clean, XcodeOptions(), @ARGV);
>+    $result = buildXCodeProject("Source/WebCore/WebCore", $clean, XcodeOptions(), (@ARGV, "-target", "WebCoreTestSupport", "-target", "WebCoreTestShim"));
>+    exit exitStatus($result) if (exitStatus($result));
>+    $result = buildXCodeProject("Tools/DumpRenderTree/DumpRenderTree", $clean, XcodeOptions(), @ARGV);
> } elsif (isGtk() || isWPE() || isAnyWindows()) {
>     # GTK, WPE and Windows build everything in one shot. No need to build anything here.
>     $result = 0;
>Index: Tools/Scripts/build-webkittestrunner
>===================================================================
>--- Tools/Scripts/build-webkittestrunner	(revision 241924)
>+++ Tools/Scripts/build-webkittestrunner	(working copy)
>@@ -57,11 +57,11 @@ setConfiguration();
> chdirWebKit();
> 
> # Build
>-chdir "Tools/WebKitTestRunner" or die;
>-
> my $result;
> if (isAppleCocoaWebKit()) {
>-    $result = buildXCodeProject("WebKitTestRunner", $clean, XcodeOptions(), @ARGV);
>+    $result = buildXCodeProject("Source/WebCore/WebCore", $clean, XcodeOptions(), (@ARGV, "-target", "WebCoreTestSupport", "-target", "WebCoreTestShim"));
>+    exit exitStatus($result) if (exitStatus($result));
>+    $result = buildXCodeProject("Tools/WebKitTestRunner/WebKitTestRunner", $clean, XcodeOptions(), @ARGV);
> } elsif (isGtk() || isWPE() || isPlayStation() || isAnyWindows()) {
>     # GTK+, WPE, PlayStation, and Windows build everything in one shot. No need to build anything here.
>     $result = 0;

Actions: View | Formatted Diff | Diff

Attachments on bug 194917: 362640 | 362724