Attachment 362704 Details for Bug 160172 – Patch

[patch] Patch

bug-160172-20190222094726.patch (text/plain), 2.35 KB, created by Rob Buis on 2019-02-22 00:47:28 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Buis

Created: 2019-02-22 00:47:28 PST

Size: 2.35 KB

patch

obsolete

>Subversion Revision: 241761
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index a6da53fe8e04ad79dd06c117c410a040b2b97e76..6683f11763184531eb3b280429295d1bf4dfbf73 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-02-22  Rob Buis  <rbuis@igalia.com>
>+
>+        Move and rename stripLeadingAndTrailingWhitespace in MathMLElement.cpp to HTMLParserIdioms.cpp
>+        https://bugs.webkit.org/show_bug.cgi?id=160172
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * mathml/MathMLElement.cpp:
>+        (WebCore::MathMLElement::stripLeadingAndTrailingWhitespace):
>+        * mathml/MathMLElement.h:
>+
> 2019-02-19  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r241722.
>diff --git a/Source/WebCore/mathml/MathMLElement.cpp b/Source/WebCore/mathml/MathMLElement.cpp
>index 5ffa23f241e00ad403fec6781d17638103628d7d..55c3f22d74a412b7d54b9c7336c576b9759c3468 100644
>--- a/Source/WebCore/mathml/MathMLElement.cpp
>+++ b/Source/WebCore/mathml/MathMLElement.cpp
>@@ -210,16 +210,9 @@ int MathMLElement::tabIndex() const
>     return Element::tabIndex();
> }
> 
>-StringView MathMLElement::stripLeadingAndTrailingWhitespace(const StringView& stringView)
>+StringView MathMLElement::stripLeadingAndTrailingWhitespace(StringView stringView)
> {
>-    unsigned start = 0, stringLength = stringView.length();
>-    while (stringLength > 0 && isHTMLSpace(stringView[start])) {
>-        start++;
>-        stringLength--;
>-    }
>-    while (stringLength > 0 && isHTMLSpace(stringView[start + stringLength - 1]))
>-        stringLength--;
>-    return stringView.substring(start, stringLength);
>+    return stringView.stripLeadingAndTrailingMatchedCharacters(isHTMLSpace<UChar>);
> }
> 
> }
>diff --git a/Source/WebCore/mathml/MathMLElement.h b/Source/WebCore/mathml/MathMLElement.h
>index b35f0165c687ad429430c3e7ad60ab7e35e2ed74..f42669fdafdba189d1d3d064ff8cda3b9420f07d 100644
>--- a/Source/WebCore/mathml/MathMLElement.h
>+++ b/Source/WebCore/mathml/MathMLElement.h
>@@ -93,7 +93,7 @@ public:
> protected:
>     MathMLElement(const QualifiedName& tagName, Document&);
> 
>-    static StringView stripLeadingAndTrailingWhitespace(const StringView&);
>+    static StringView stripLeadingAndTrailingWhitespace(StringView);
> 
>     void parseAttribute(const QualifiedName&, const AtomicString&) override;
>     bool childShouldCreateRenderer(const Node&) const override;

Actions: View | Formatted Diff | Diff

Attachments on bug 160172: 284544 | 284586 | 284589 | 284593 | 285527 | 362704 | 362713 | 362714 | 362716 | 362718 | 362719