Attachment 362690 Details for Bug 194931 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

unused-1.patch (text/plain), 4.87 KB, created by Joseph Pecoraro on 2019-02-21 20:45:27 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-02-21 20:45:27 PST

Size: 4.87 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index e6629aa3c7e..85b0d848739 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-02-21  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Remove unused Timeline record selection code path
>+        https://bugs.webkit.org/show_bug.cgi?id=194931
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/TimelineOverview.js:
>+        (WI.TimelineOverview):
>+        (WI.TimelineOverview.prototype.userSelectedRecord): Deleted.
>+        * UserInterface/Views/TimelineRecordingContentView.js:
>+        (WI.TimelineRecordingContentView):
>+        (WI.TimelineRecordingContentView.prototype.timelineOverviewUserSelectedRecord): Deleted.
>+        * UserInterface/Views/TimelineView.js:
>+        (WI.TimelineView.prototype.userSelectedRecordFromOverview): Deleted.
>+
> 2019-02-18  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: CPU Usage Timeline - Thread Breakdown
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js b/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js
>index 5c79c608e37..1c8b705aed6 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js
>@@ -25,7 +25,7 @@
> 
> WI.TimelineOverview = class TimelineOverview extends WI.View
> {
>-    constructor(timelineRecording, delegate)
>+    constructor(timelineRecording)
>     {
>         super();
> 
>@@ -46,8 +46,6 @@ WI.TimelineOverview = class TimelineOverview extends WI.View
>         this._recording.addEventListener(WI.TimelineRecording.Event.MarkerAdded, this._markerAdded, this);
>         this._recording.addEventListener(WI.TimelineRecording.Event.Reset, this._recordingReset, this);
> 
>-        this._delegate = delegate;
>-
>         this.element.classList.add("timeline-overview");
>         this._updateWheelAndGestureHandlers();
> 
>@@ -411,12 +409,6 @@ WI.TimelineOverview = class TimelineOverview extends WI.View
>         overviewGraph.selectedRecord = record;
>     }
> 
>-    userSelectedRecord(record)
>-    {
>-        if (this._delegate && this._delegate.timelineOverviewUserSelectedRecord)
>-            this._delegate.timelineOverviewUserSelectedRecord(this, record);
>-    }
>-
>     updateLayoutIfNeeded(layoutReason)
>     {
>         if (this.layoutPending) {
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js b/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js
>index 4c70505926b..a6d1066a933 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js
>@@ -34,7 +34,7 @@ WI.TimelineRecordingContentView = class TimelineRecordingContentView extends WI.
> 
>         this.element.classList.add("timeline-recording");
> 
>-        this._timelineOverview = new WI.TimelineOverview(this._recording, this);
>+        this._timelineOverview = new WI.TimelineOverview(this._recording);
>         this._timelineOverview.addEventListener(WI.TimelineOverview.Event.TimeRangeSelectionChanged, this._timeRangeSelectionChanged, this);
>         this._timelineOverview.addEventListener(WI.TimelineOverview.Event.RecordSelected, this._recordSelected, this);
>         this._timelineOverview.addEventListener(WI.TimelineOverview.Event.TimelineSelected, this._timelineSelected, this);
>@@ -262,25 +262,6 @@ WI.TimelineRecordingContentView = class TimelineRecordingContentView extends WI.
>         return new WI.GeneralTreeElement(iconClassName, title, representedObject, hasChildren);
>     }
> 
>-    // TimelineOverview delegate
>-
>-    timelineOverviewUserSelectedRecord(timelineOverview, timelineRecord)
>-    {
>-        let timelineViewForRecord = null;
>-        for (let timelineView of this._timelineViewMap.values()) {
>-            if (timelineView.representedObject.type === timelineRecord.type) {
>-                timelineViewForRecord = timelineView;
>-                break;
>-            }
>-        }
>-
>-        if (!timelineViewForRecord)
>-            return;
>-
>-        this._timelineContentBrowser.showContentView(timelineViewForRecord);
>-        timelineViewForRecord.userSelectedRecordFromOverview(timelineRecord);
>-    }
>-
>     // Private
> 
>     _currentContentViewDidChange(event)
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TimelineView.js b/Source/WebInspectorUI/UserInterface/Views/TimelineView.js
>index 97b888c739d..23842f2c085 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TimelineView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TimelineView.js
>@@ -295,11 +295,6 @@ WI.TimelineView = class TimelineView extends WI.ContentView
> 
>     // Protected
> 
>-    userSelectedRecordFromOverview(timelineRecord)
>-    {
>-        // Implemented by sub-classes if needed.
>-    }
>-
>     filterDidChange()
>     {
>         // Implemented by sub-classes if needed.

Actions: View | Formatted Diff | Diff

Attachments on bug 194931: 362690