Attachment 362662 Details for Bug 194923 – Patch

[patch] Patch

bug-194923-20190221162122.patch (text/plain), 2.03 KB, created by Eric Liang on 2019-02-21 16:21:23 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Liang

Created: 2019-02-21 16:21:23 PST

Size: 2.03 KB

patch

obsolete

>Subversion Revision: 241874
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2399fa5be124d0412e0665898fc95b005956205a..6f9d17a97b247e4ad65bc83fd6a75bf68c27097f 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-02-21  Eric Liang  <ericliang@apple.com>
>+
>+        AX: Treat AXChildrenInNavigationOrder as AXChildren before adding support for aria-flowto
>+        https://bugs.webkit.org/show_bug.cgi?id=194923
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests created.
>+
>+        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
>+        (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
>+
> 2019-02-21  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][Floats] Add support for placing formatting roots in-between floats.
>diff --git a/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm b/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
>index f7445912f1814f6acde1ab29fa0658e8c40cde7b..446d358cf03a73b1d299762fc2cd4abe91b8d702 100644
>--- a/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
>+++ b/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
>@@ -153,6 +153,10 @@ using namespace HTMLNames;
> #define NSAccessibilityBlockQuoteLevelAttribute @"AXBlockQuoteLevel"
> #endif
> 
>+#ifndef NSAccessibilityChildrenInNavigationOrderAttribute
>+#define NSAccessibilityChildrenInNavigationOrderAttribute @"AXChildrenInNavigationOrder"
>+#endif
>+
> #ifndef NSAccessibilityAccessKeyAttribute
> #define NSAccessibilityAccessKeyAttribute @"AXAccessKey"
> #endif
>@@ -2482,7 +2486,7 @@ IGNORE_WARNINGS_END
>         return parent->wrapper();
>     }
>     
>-    if ([attributeName isEqualToString: NSAccessibilityChildrenAttribute]) {
>+    if ([attributeName isEqualToString: NSAccessibilityChildrenAttribute] || [attributeName isEqualToString: NSAccessibilityChildrenInNavigationOrderAttribute]) {
>         if (!self.childrenVectorSize) {
>             NSArray* children = [self renderWidgetChildren];
>             if (children != nil)

Actions: View | Formatted Diff | Diff

Attachments on bug 194923: 362662 | 362770 | 362772 | 362797 | 362810 | 362813