Attachment 362651 Details for Bug 194481 – Patch

[patch] Patch

bug-194481-20190221150548.patch (text/plain), 1.85 KB, created by Chris Dumez on 2019-02-21 15:05:49 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2019-02-21 15:05:49 PST

Size: 1.85 KB

patch

obsolete

>Subversion Revision: 241900
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 44db4426f3eb8fe15e69094ae3440bf6e5efca65..a1d5b00186682e43350fee081ddeeae9b78ea11c 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-02-21  Chris Dumez  <cdumez@apple.com>
>+
>+        Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
>+        https://bugs.webkit.org/show_bug.cgi?id=194481
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Give the processes a chance to shutdown and wait until we reached the expected number
>+        of processes.
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
>+
> 2019-02-21  Tim Horton  <timothy_horton@apple.com>
> 
>         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>index 499d2b6e251995d12a3593fc133983ccbcf70aa1..b2ff790ec69c473a242dfb1869745df29c22fbb0 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>@@ -2946,7 +2946,14 @@ TEST(ProcessSwap, SuspendedPageLimit)
>     EXPECT_EQ(5u, seenPIDs.size());
> 
>     // But not all of those processes should still be alive (1 visible, maximumSuspendedPageCount suspended).
>-    EXPECT_EQ([processPool _webProcessCountIgnoringPrewarmedAndCached], (1U + maximumSuspendedPageCount));
>+    auto expectedProcessCount = 1 + maximumSuspendedPageCount;
>+    int timeout = 20;
>+    while ([processPool _webProcessCountIgnoringPrewarmedAndCached] != expectedProcessCount && timeout >= 0) {
>+        TestWebKitAPI::Util::sleep(0.1);
>+        --timeout;
>+    }
>+
>+    EXPECT_EQ(expectedProcessCount, [processPool _webProcessCountIgnoringPrewarmedAndCached]);
> }
> 
> TEST(ProcessSwap, PageCache1)

Actions: View | Formatted Diff | Diff

Attachments on bug 194481: 362651