Attachment 362641 Details for Bug 194918 – Patch

[patch] Patch

bug-194918-20190221135720.patch (text/plain), 2.56 KB, created by Matt Baker on 2019-02-21 13:57:20 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2019-02-21 13:57:20 PST

Size: 2.56 KB

patch

obsolete

>Subversion Revision: 241876
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index fce7a3e86b94317037527189770742a439698881..32c9d49d8de0400dfde55fa49ea41534ece14014 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-02-21  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: REGRESSION: TreeElement or Table row selected using the keyboard should always be revealed
>+        https://bugs.webkit.org/show_bug.cgi?id=194918
>+        <rdar://problem/48289314>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/Table.js:
>+        (WI.Table.prototype.selectionControllerSelectionDidChange):
>+
>+        * UserInterface/Views/TreeOutline.js:
>+        (WI.TreeOutline.prototype._treeKeyDown):
>+
> 2019-02-21  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Canvas: recordings with a single frame sometimes missing TreeElement
>diff --git a/Source/WebInspectorUI/UserInterface/Views/Table.js b/Source/WebInspectorUI/UserInterface/Views/Table.js
>index 0628f4813d91545fcf5c28378a854f1a3114c547..68df935b7dc4d32336a9fa39ea26199af7e059d7 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/Table.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/Table.js
>@@ -619,10 +619,9 @@ WI.Table = class Table extends WI.View
>                 row.classList.toggle("selected", true);
>         }
> 
>-        if (selectedItems.size === 1) {
>-            let rowIndex = this._indexForRepresentedObject(selectedItems.firstValue);
>-            if (!this._isRowVisible(rowIndex))
>-                this.revealRow(rowIndex);
>+        if (this._selectionController.lastSelectedItem) {
>+            let rowIndex = this._indexForRepresentedObject(this._selectionController.lastSelectedItem);
>+            this.revealRow(rowIndex);
>         }
> 
>         if (this._delegate.tableSelectionDidChange)
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>index 98159e79cc9772e222b0f5d88e12bff165ebac30..344ccb29835e1b1babb73bb24e7f26beaa3520ac 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>@@ -660,6 +660,9 @@ WI.TreeOutline = class TreeOutline extends WI.Object
>             this._itemWasSelectedByUser = true;
>             handled = this._selectionController.handleKeyDown(event);
>             this._itemWasSelectedByUser = false;
>+
>+            if (handled)
>+                nextSelectedElement = this.selectedTreeElement;
>         }
> 
>         if (nextSelectedElement) {

Actions: View | Formatted Diff | Diff

Attachments on bug 194918: 362641