WebKit Bugzilla
Attachment 362640 Details for
Bug 194917
: build-dumprendertree, build-webkittestrunner: Build WebCore test support libraries
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-194917-20190221135545.patch (text/plain), 2.40 KB, created by
Jonathan Bedard
on 2019-02-21 13:55:46 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Jonathan Bedard
Created:
2019-02-21 13:55:46 PST
Size:
2.40 KB
patch
obsolete
>Index: Tools/ChangeLog >=================================================================== >--- Tools/ChangeLog (revision 241900) >+++ Tools/ChangeLog (working copy) >@@ -1,3 +1,14 @@ >+2019-02-21 Jonathan Bedard <jbedard@apple.com> >+ >+ build-dumprendertree, build-webkittestrunner: Build WebCore test support libraries >+ https://bugs.webkit.org/show_bug.cgi?id=194917 >+ <rdar://problem/48278600> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Scripts/build-dumprendertree: Build WebCoreTestSupport and WebCoreTestShim. >+ * Scripts/build-webkittestrunner: Ditto. >+ > 2019-02-21 Tim Horton <timothy_horton@apple.com> > > Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process >Index: Tools/Scripts/build-dumprendertree >=================================================================== >--- Tools/Scripts/build-dumprendertree (revision 241875) >+++ Tools/Scripts/build-dumprendertree (working copy) >@@ -66,6 +66,10 @@ chdir File::Spec->catdir("Tools", "DumpR > my $result; > if (isAppleCocoaWebKit()) { > $result = buildXCodeProject("DumpRenderTree", $clean, XcodeOptions(), @ARGV); >+ exit exitStatus($result) if (exitStatus($result)); >+ >+ chdir File::Spec->catdir("..", "..", "Source", "WebCore") or die; >+ $result = buildXCodeProject("WebCore", $clean, XcodeOptions(), (@ARGV, "-target", "WebCoreTestSupport", "-target", "WebCoreTestShim")); > } elsif (isGtk() || isWPE() || isAnyWindows()) { > # GTK, WPE and Windows build everything in one shot. No need to build anything here. > $result = 0; >Index: Tools/Scripts/build-webkittestrunner >=================================================================== >--- Tools/Scripts/build-webkittestrunner (revision 241875) >+++ Tools/Scripts/build-webkittestrunner (working copy) >@@ -62,6 +62,10 @@ chdir "Tools/WebKitTestRunner" or die; > my $result; > if (isAppleCocoaWebKit()) { > $result = buildXCodeProject("WebKitTestRunner", $clean, XcodeOptions(), @ARGV); >+ exit exitStatus($result) if (exitStatus($result)); >+ >+ chdir File::Spec->catdir("..", "..", "Source", "WebCore") or die; >+ $result = buildXCodeProject("WebCore", $clean, XcodeOptions(), (@ARGV, "-target", "WebCoreTestSupport", "-target", "WebCoreTestShim")); > } elsif (isGtk() || isWPE() || isPlayStation() || isAnyWindows()) { > # GTK+, WPE, PlayStation, and Windows build everything in one shot. No need to build anything here. > $result = 0;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194917
:
362640
|
362724