Attachment 362603 Details for Bug 194898 – Patch

[patch] Patch

bug-194898-20190221151252.patch (text/plain), 1.55 KB, created by Charlie Turner on 2019-02-21 07:12:53 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Charlie Turner

Created: 2019-02-21 07:12:53 PST

Size: 1.55 KB

patch

obsolete

>Subversion Revision: 241790
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 96708e79bad6a035a8ef720dba9a8e63d295b9b1..1a6d7b5b47900b51e35d54ee57ae017849525161 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-02-21  Charlie Turner  <cturner@igalia.com>
>+
>+        [WPE] Condition use of wl_array_for_each on GCC
>+        https://bugs.webkit.org/show_bug.cgi?id=194898
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
>+        a GCC extension where arithmetic on void* pointers is
>+        permitted. When compiling with Clang, this is not allowed.
>+
> 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
> 
>         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
>diff --git a/Tools/wpe/backends/WindowViewBackend.cpp b/Tools/wpe/backends/WindowViewBackend.cpp
>index 20f03b80babdd386612adc3ccee23256c8cbf3d5..eb24ba5422e46a985831131265ca89bfaf168ede 100644
>--- a/Tools/wpe/backends/WindowViewBackend.cpp
>+++ b/Tools/wpe/backends/WindowViewBackend.cpp
>@@ -439,7 +439,7 @@ const struct zxdg_toplevel_v6_listener WindowViewBackend::s_xdgToplevelListener
>         auto& window = *static_cast<WindowViewBackend*>(data);
>         wpe_view_backend_dispatch_set_size(window.backend(), width, height);
> 
>-#if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(1, 1, 0)
>+#if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(1, 1, 0) && (defined(__GNUC__) && !defined(__clang__))
>         bool isFocused = false;
>         void* p;
>         wl_array_for_each(p, states)

Actions: View | Formatted Diff | Diff

Attachments on bug 194898: 362603 | 362715 | 362722