Attachment 362577 Details for Bug 194887 – Patch

[patch] Patch

bug-194887-20190220172941.patch (text/plain), 2.02 KB, created by Tim Horton on 2019-02-20 17:29:42 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Horton

Created: 2019-02-20 17:29:42 PST

Size: 2.02 KB

patch

obsolete

>Subversion Revision: 241855
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index a643abd0c9fc36cbdfb21bf4709157ec1264ac05..b46bfc1a3597735808523fd7b8418dcbc4aae5d6 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-02-20  Tim Horton  <timothy_horton@apple.com>
>+
>+        Turn a high-value UI-side-compositing assertion into a release assert
>+        https://bugs.webkit.org/show_bug.cgi?id=194887
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:
>+        (WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
>+        There is absolutely no situation in which this assert should fire
>+        if WebKit is behaving correctly, and it will basically always result
>+        in a UI process crash (or at least confusion), so make it a release assert.
>+        This would have saved us a lot of stress in bug 194845.
>+
> 2019-02-20  Chris Dumez  <cdumez@apple.com>
> 
>         [PSON] Make sure hung processes are not kept alive by suspended pages or process caching
>diff --git a/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp b/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp
>index eca95e79ad7c380c33aa90532bb4dadc30952974..313ed7e2c46ddceb1bcfbf339fde2d6569bb3f1e 100644
>--- a/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp
>+++ b/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp
>@@ -156,7 +156,7 @@ void PlatformCALayerRemote::updateClonedLayerProperties(PlatformCALayerRemote& c
> void PlatformCALayerRemote::recursiveBuildTransaction(RemoteLayerTreeContext& context, RemoteLayerTreeTransaction& transaction)
> {
>     ASSERT(!m_properties.backingStore || owner());
>-    ASSERT_WITH_SECURITY_IMPLICATION(&context == m_context);
>+    RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(&context == m_context);
>     
>     if (m_properties.backingStore && (!owner() || !owner()->platformCALayerDrawsContent())) {
>         m_properties.backingStore = nullptr;

Actions: View | Formatted Diff | Diff

Attachments on bug 194887: 362577