Attachment 362554 Details for Bug 194874 – Patch

[patch] Patch

bug-194874-20190220153332.patch (text/plain), 2.05 KB, created by Devin Rousso on 2019-02-20 15:33:32 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-02-20 15:33:32 PST

Size: 2.05 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 276a49be0d138579541bc14fdf2d81804fb5c01b..2ed4958024e6ae1a732b0419541d5a746399bdf0 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-02-20  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: DOM Debugger: node-specific event breakpoints aren't cleared/recalculated on navigation
>+        https://bugs.webkit.org/show_bug.cgi?id=194874
>+        <rdar://problem/48253415>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Controllers/DOMManager.js:
>+        (WI.DOMManager.prototype._setDocument):
>+        (WI.DOMManager.prototype.removeBreakpointForEventListener):
>+
> 2019-02-19  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: Improve ES6 Class instances in Heap Snapshot instances view
>diff --git a/Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js b/Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js
>index 8a024c9d5f7c161386c25ed2c860433fc9c85317..95ecfc6f54141f9181823aea269a457c9c68e21f 100644
>--- a/Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js
>+++ b/Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js
>@@ -279,6 +279,9 @@ WI.DOMManager = class DOMManager extends WI.Object
>     _setDocument(payload)
>     {
>         this._idToDOMNode = {};
>+
>+        for (let breakpoint of this._breakpointsForEventListeners.values())
>+            WI.domDebuggerManager.dispatchEventToListeners(WI.DOMDebuggerManager.Event.EventBreakpointRemoved, {breakpoint});
>         this._breakpointsForEventListeners.clear();
> 
>         let newDocument = null;
>@@ -652,8 +655,7 @@ WI.DOMManager = class DOMManager extends WI.Object
>                 return;
>             }
> 
>-            if (breakpoint)
>-                WI.domDebuggerManager.dispatchEventToListeners(WI.DOMDebuggerManager.Event.EventBreakpointRemoved, {breakpoint});
>+            WI.domDebuggerManager.dispatchEventToListeners(WI.DOMDebuggerManager.Event.EventBreakpointRemoved, {breakpoint});
>         });
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194874: 362554