Attachment 362543 Details for Bug 194870 – Patch

[patch] Patch

bug-194870-20190220143453.patch (text/plain), 2.09 KB, created by Sihui Liu on 2019-02-20 14:34:53 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2019-02-20 14:34:53 PST

Size: 2.09 KB

patch

obsolete

>Subversion Revision: 241817
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 24a9da37dfaf22e6b031d8f5e8350f331988afca..34c5311d6a83d71dbc6cb7c92576df9a482156f7 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2019-02-20  Sihui Liu  <sihui_liu@apple.com>
>+
>+        IndexedDB: leak UniqueIDBDatabase in layout tests
>+        https://bugs.webkit.org/show_bug.cgi?id=194870
>+        <rdar://problem/48163812>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        UniqueIDBDatabase owns a pointer to itself after it is hard closed. It should release the pointer when it 
>+        receives confirmation from clients and all pending tasks are done. UniqueIDBDatabase already checks whether the
>+        pointer should be released when a database task finishes, but it didn't perform a check when a confirm message 
>+        is received. 
>+
>+        No new test as the order of task completion and confirmation arrival is uncertain.
>+
>+        * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
>+        (WebCore::IDBServer::UniqueIDBDatabase::confirmDidCloseFromServer):
>+
> 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
> 
>         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
>diff --git a/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp b/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
>index 722e7e94682d3456ad71bf5ec622b1e0c4356d63..87d701a52fb8ef86f78d3e17c20e3287ee839fe0 100644
>--- a/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
>+++ b/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
>@@ -1519,6 +1519,8 @@ void UniqueIDBDatabase::confirmDidCloseFromServer(UniqueIDBDatabaseConnection& c
>     ASSERT(isMainThread());
>     LOG(IndexedDB, "UniqueIDBDatabase::confirmDidCloseFromServer - %s (%" PRIu64 ")", connection.openRequestIdentifier().loggingString().utf8().data(), connection.identifier());
> 
>+    if (m_hardClosedForUserDelete)
>+        maybeFinishHardClose();
>     ASSERT(m_serverClosePendingDatabaseConnections.contains(&connection));
>     m_serverClosePendingDatabaseConnections.remove(&connection);
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 194870: 362543