Attachment 362528 Details for Bug 194866 – Patch

[patch] Patch

bug-194866-20190220130223.patch (text/plain), 1.78 KB, created by Simon Fraser (smfr) on 2019-02-20 13:02:24 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2019-02-20 13:02:24 PST

Size: 1.78 KB

patch

obsolete

>Subversion Revision: 241829
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index ee42d1e19ceabcbec0f21377f9a2eb90f18aaa0d..23fc04a8721c912dcf8f59a945a4026dce0cfe11 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-02-20  Simon Fraser  <simon.fraser@apple.com>
>+
>+        REGRESSION (r241788>): ASSERTION FAILED: !m_normalFlowListDirty in TestWebKitAPI.WebKit.ResizeReversePaginatedWebView test
>+        https://bugs.webkit.org/show_bug.cgi?id=194866
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        r241788 removed some calls that updated layer lists (normal flow and z-order) during compositing updates, causing
>+        a later call to RenderLayerCompositor::recursiveRepaintLayer() to assert when the lists were dirty. Fix by updating
>+        the lists in RenderLayerCompositor::recursiveRepaintLayer(), as we do in various other places.
>+
>+        * rendering/RenderLayerCompositor.cpp:
>+        (WebCore::RenderLayerCompositor::recursiveRepaintLayer):
>+
> 2019-02-20  Daniel Bates  <dabates@apple.com>
> 
>         [iOS] Tweak UI for focus rings
>diff --git a/Source/WebCore/rendering/RenderLayerCompositor.cpp b/Source/WebCore/rendering/RenderLayerCompositor.cpp
>index 703457c70f754da71bdcfba161f35fbc2abcccc8..6dd8d1525a7ee2f43443c9fdf91e9544b7855812 100644
>--- a/Source/WebCore/rendering/RenderLayerCompositor.cpp
>+++ b/Source/WebCore/rendering/RenderLayerCompositor.cpp
>@@ -1991,6 +1991,8 @@ void RenderLayerCompositor::repaintCompositedLayers()
> 
> void RenderLayerCompositor::recursiveRepaintLayer(RenderLayer& layer)
> {
>+    layer.updateLayerListsIfNeeded();
>+
>     // FIXME: This method does not work correctly with transforms.
>     if (layer.isComposited() && !layer.backing()->paintsIntoCompositedAncestor())
>         layer.setBackingNeedsRepaint();

Flags:

koivisto: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 194866: 362528