Attachment 362456 Details for Bug 194844 – Patch

[patch] Patch

bug-194844.diff (text/plain), 2.92 KB, created by Don Olmstead on 2019-02-19 17:13:56 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Don Olmstead

Created: 2019-02-19 17:13:56 PST

Size: 2.92 KB

patch

obsolete

>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 91019bbd17a..2a80096b5cc 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-02-19  Don Olmstead  <don.olmstead@sony.com>
>+
>+        [Win] Set additional directories within WebsiteDataStore
>+        https://bugs.webkit.org/show_bug.cgi?id=194844
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Adds the device hash salts storage directories. Sets the default data store directories for
>+        IndexedDB, Service Worker, and the Device ID Hash Salts.
>+
>+        * UIProcess/API/win/APIWebsiteDataStoreWin.cpp:
>+        (API::WebsiteDataStore::defaultDeviceIdHashSaltsStorageDirectory):
>+        (API::WebsiteDataStore::legacyDefaultDeviceIdHashSaltsStorageDirectory):
>+        (API::WebsiteDataStore::defaultDataStoreConfiguration):
>+
> 2019-02-19  Antti Koivisto  <antti@apple.com>
> 
>         Pass rootContentsLayer to Mac remote layer tree
>diff --git a/Source/WebKit/UIProcess/API/win/APIWebsiteDataStoreWin.cpp b/Source/WebKit/UIProcess/API/win/APIWebsiteDataStoreWin.cpp
>index 3225b92170d..72815f4369f 100644
>--- a/Source/WebKit/UIProcess/API/win/APIWebsiteDataStoreWin.cpp
>+++ b/Source/WebKit/UIProcess/API/win/APIWebsiteDataStoreWin.cpp
>@@ -67,8 +67,7 @@ String WebsiteDataStore::defaultMediaKeysStorageDirectory()
> 
> String WebsiteDataStore::defaultDeviceIdHashSaltsStorageDirectory()
> {
>-    // Not Implemented.
>-    return String();
>+    return FileSystem::pathByAppendingComponent(FileSystem::localUserSpecificStorageDirectory(), "DeviceIdHashSalts");
> }
> 
> String WebsiteDataStore::defaultWebSQLDatabaseDirectory()
>@@ -128,8 +127,7 @@ String WebsiteDataStore::legacyDefaultMediaKeysStorageDirectory()
> 
> String WebsiteDataStore::legacyDefaultDeviceIdHashSaltsStorageDirectory()
> {
>-    // Not Implemented.
>-    return String();
>+    return FileSystem::pathByAppendingComponent(FileSystem::localUserSpecificStorageDirectory(), "DeviceIdHashSalts");
> }
> 
> String WebsiteDataStore::legacyDefaultJavaScriptConfigurationDirectory()
>@@ -143,10 +141,14 @@ Ref<WebKit::WebsiteDataStoreConfiguration> WebsiteDataStore::defaultDataStoreCon
> 
>     configuration->setApplicationCacheDirectory(defaultApplicationCacheDirectory());
>     configuration->setNetworkCacheDirectory(defaultNetworkCacheDirectory());
>+
>+    configuration->setIndexedDBDatabaseDirectory(defaultIndexedDBDatabaseDirectory());
>+    configuration->setServiceWorkerRegistrationDirectory(defaultServiceWorkerRegistrationDirectory());
>     configuration->setWebSQLDatabaseDirectory(defaultWebSQLDatabaseDirectory());
>     configuration->setLocalStorageDirectory(defaultLocalStorageDirectory());
>     configuration->setMediaKeysStorageDirectory(defaultMediaKeysStorageDirectory());
>     configuration->setResourceLoadStatisticsDirectory(defaultResourceLoadStatisticsDirectory());
>+    configuration->setDeviceIdHashSaltsStorageDirectory(defaultDeviceIdHashSaltsStorageDirectory());
> 
>     return configuration;
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 194844: 362456 | 362463 | 362465 | 363359 | 363360 | 363363