Attachment 362450 Details for Bug 194840 – Patch

[patch] Patch

bug-194840-20190219162432.patch (text/plain), 1.50 KB, created by Alex Christensen on 2019-02-19 16:24:33 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2019-02-19 16:24:33 PST

Size: 1.50 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 241784)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2019-02-19  Alex Christensen  <achristensen@webkit.org>
>+
>+        Change RELEASE_ASSERT from r236512 to MESSAGE_CHECK
>+        https://bugs.webkit.org/show_bug.cgi?id=194840
>+        <rdar://problem/47759323>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/WebPageProxy.cpp:
>+        (WebKit::WebPageProxy::decidePolicyForNavigationActionSync):
>+        We are seeing a few crashes from this assertion, which can only come from
>+        if the main frame and the process are in an inconsistent state.
>+        In this case, a message check will reset the state.
>+
> 2019-02-19  Antti Koivisto  <antti@apple.com>
> 
>         Pass rootContentsLayer to Mac remote layer tree
>Index: Source/WebKit/UIProcess/WebPageProxy.cpp
>===================================================================
>--- Source/WebKit/UIProcess/WebPageProxy.cpp	(revision 241754)
>+++ Source/WebKit/UIProcess/WebPageProxy.cpp	(working copy)
>@@ -4632,7 +4632,7 @@ void WebPageProxy::decidePolicyForNaviga
>             didCreateSubframe(frameID);
> 
>         frame = m_process->webFrame(frameID);
>-        RELEASE_ASSERT(frame);
>+        MESSAGE_CHECK(m_process, frame);
>     }
> 
>     decidePolicyForNavigationAction(m_process.copyRef(), *frame, WTFMove(frameSecurityOrigin), navigationID, WTFMove(navigationActionData), WTFMove(frameInfoData),

Flags:

cdumez: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 194840: 362450