Attachment 362438 Details for Bug 194831 – Patch

[patch] Patch

patch194831 (text/plain), 1.44 KB, created by Robin Morisset on 2019-02-19 14:56:03 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Robin Morisset

Created: 2019-02-19 14:56:03 PST

Size: 1.44 KB

patch

obsolete

>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 2037305202e..0e81a651ca7 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-02-19  Robin Morisset  <rmorisset@apple.com>
>+
>+        CachedCall should not consider it UNLIKELY that it will not stack overflow
>+        https://bugs.webkit.org/show_bug.cgi?id=194831
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * interpreter/CachedCall.h:
>+        (JSC::CachedCall::CachedCall):
>+
> 2019-02-18  Yusuke Suzuki  <ysuzuki@apple.com>
> 
>         [JSC] Introduce JSNonDestructibleProxy for JavaScriptCore.framework's GlobalThis
>diff --git a/Source/JavaScriptCore/interpreter/CachedCall.h b/Source/JavaScriptCore/interpreter/CachedCall.h
>index c20a85556b7..80d79779444 100644
>--- a/Source/JavaScriptCore/interpreter/CachedCall.h
>+++ b/Source/JavaScriptCore/interpreter/CachedCall.h
>@@ -49,7 +49,7 @@ namespace JSC {
>             auto scope = DECLARE_THROW_SCOPE(vm);
> 
>             ASSERT(!function->isHostFunctionNonInline());
>-            if (UNLIKELY(vm.isSafeToRecurseSoft())) {
>+            if (LIKELY(vm.isSafeToRecurseSoft())) {
>                 m_arguments.ensureCapacity(argumentCount);
>                 if (LIKELY(!m_arguments.hasOverflowed()))
>                     m_closure = m_interpreter->prepareForRepeatCall(function->jsExecutable(), callFrame, &m_protoCallFrame, function, argumentCount + 1, function->scope(), m_arguments);

Actions: View | Formatted Diff | Diff

Attachments on bug 194831: 362438