Attachment 362417 Details for Bug 194823 – Patch

[patch] Patch

bug-194823-20190219125719.patch (text/plain), 1.73 KB, created by Alex Christensen on 2019-02-19 12:57:20 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2019-02-19 12:57:20 PST

Size: 1.73 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 241767)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-02-19  Alex Christensen  <achristensen@webkit.org>
>+
>+        Always call CompletionHandlers after r240909
>+        https://bugs.webkit.org/show_bug.cgi?id=194823
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * loader/PolicyChecker.cpp:
>+        (WebCore::PolicyChecker::checkNavigationPolicy):
>+        (WebCore::PolicyChecker::checkNewWindowPolicy):
>+
> 2019-02-19  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r241722.
>Index: Source/WebCore/loader/PolicyChecker.cpp
>===================================================================
>--- Source/WebCore/loader/PolicyChecker.cpp	(revision 241753)
>+++ Source/WebCore/loader/PolicyChecker.cpp	(working copy)
>@@ -193,7 +193,7 @@ void PolicyChecker::checkNavigationPolic
>          blobURLLifetimeExtension = WTFMove(blobURLLifetimeExtension), requestIdentifier] (PolicyAction policyAction, PolicyCheckIdentifier responseIdentifier) mutable {
> 
>         if (!responseIdentifier.isValidFor(requestIdentifier))
>-            return;
>+            return function({ }, nullptr, NavigationPolicyDecision::IgnoreLoad);
> 
>         m_delegateIsDecidingNavigationPolicy = false;
> 
>@@ -234,7 +234,7 @@ void PolicyChecker::checkNewWindowPolicy
>         requestIdentifier] (PolicyAction policyAction, PolicyCheckIdentifier responseIdentifier) mutable {
> 
>         if (!responseIdentifier.isValidFor(requestIdentifier))
>-            return;
>+            return function({ }, nullptr, { }, { }, ShouldContinue::No);
> 
>         switch (policyAction) {
>         case PolicyAction::Download:

Actions: View | Formatted Diff | Diff

Attachments on bug 194823: 362404 | 362417