Attachment 362408 Details for Bug 194825 – Patch

[patch] Patch

bug-194825-20190219120738.patch (text/plain), 1.91 KB, created by Alex Christensen on 2019-02-19 12:07:39 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2019-02-19 12:07:39 PST

Size: 1.91 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 241768)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2019-02-19  Alex Christensen  <achristensen@webkit.org>
>+
>+        Remove assertion introduced in r229683
>+        https://bugs.webkit.org/show_bug.cgi?id=194825
>+        <rdar://problem/47628258>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
>+        (WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
>+        If we reach this code and the form's original Document's Frame has been destroyed,
>+        we have already been told to submit the form so do so, just like we do if the WebPage
>+        has been destroyed.  This is a rare edge case having to do with the timing of Frame
>+        destruction and decidePolicyForNavigationAction response, which unfortunately does not
>+        reproduce with a test case unless the timing of IPC is just right.
>+
> 2019-02-19  Antoine Quint  <graouts@apple.com>
> 
>         [iOS] "touch-action: none" should not prevent text selection or tapping on a link
>Index: Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
>===================================================================
>--- Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	(revision 241753)
>+++ Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	(working copy)
>@@ -973,9 +973,11 @@ void WebFrameLoaderClient::dispatchWillS
>     auto& form = formState.form();
> 
>     auto* sourceCoreFrame = formState.sourceDocument().frame();
>-    RELEASE_ASSERT(sourceCoreFrame);
>+    if (!sourceCoreFrame)
>+        return completionHandler();
>     auto* sourceFrame = WebFrame::fromCoreFrame(*sourceCoreFrame);
>-    ASSERT(sourceFrame);
>+    if (!sourceFrame)
>+        return completionHandler();
> 
>     auto& values = formState.textFieldValues();
>

Flags:

ggaren: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 194825: 362408