Attachment 362400 Details for Bug 194821 – proposed patch.

[patch] proposed patch.

bug-194821.patch (text/plain), 2.23 KB, created by Mark Lam on 2019-02-19 11:11:18 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Lam

Created: 2019-02-19 11:11:18 PST

Size: 2.23 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 241761)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,24 @@
>+2019-02-19  Mark Lam  <mark.lam@apple.com>
>+
>+        Fix DFG doesGC() for TryGetById and ProfileType nodes.
>+        https://bugs.webkit.org/show_bug.cgi?id=194821
>+        <rdar://problem/48206690>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix doesGC() for the following nodes:
>+
>+            ProfileType:
>+                calls operationProcessTypeProfilerLogDFG(), which can calculatedClassName(),
>+                which can call JSString::tryGetValue(), which can resolve a rope.
>+
>+            TryGetById:
>+                calls operationTryGetByIdOptimize(), which can startWatchingPropertyForReplacements()
>+                on a structure, which can allocate StructureRareData.
>+
>+        * dfg/DFGDoesGC.cpp:
>+        (JSC::DFG::doesGC):
>+
> 2019-02-19  Tadeu Zagallo  <tzagallo@apple.com>
> 
>         Move bytecode cache-related filesystem code out of CodeCache
>Index: Source/JavaScriptCore/dfg/DFGDoesGC.cpp
>===================================================================
>--- Source/JavaScriptCore/dfg/DFGDoesGC.cpp	(revision 241761)
>+++ Source/JavaScriptCore/dfg/DFGDoesGC.cpp	(working copy)
>@@ -109,7 +109,6 @@ bool doesGC(Graph& graph, Node* node)
>     case ArithTrunc:
>     case ArithFRound:
>     case ArithUnary:
>-    case TryGetById:
>     case CheckStructure:
>     case CheckStructureOrEmpty:
>     case CheckStructureImmediate:
>@@ -136,7 +135,6 @@ bool doesGC(Graph& graph, Node* node)
>     case CompareBelow:
>     case CompareBelowEq:
>     case CompareEqPtr:
>-    case ProfileType:
>     case ProfileControlFlow:
>     case OverridesHasInstance:
>     case IsEmpty:
>@@ -293,6 +291,7 @@ bool doesGC(Graph& graph, Node* node)
>     case LoadVarargs:
>     case NumberToStringWithRadix:
>     case NumberToStringWithValidRadixConstant:
>+    case ProfileType:
>     case PutById:
>     case PutByIdDirect:
>     case PutByIdFlush:
>@@ -327,6 +326,7 @@ bool doesGC(Graph& graph, Node* node)
>     case ToObject:
>     case ToPrimitive:
>     case ToThis:
>+    case TryGetById:
>     case CreateThis:
>     case ObjectCreate:
>     case ObjectKeys:

Actions: View | Formatted Diff | Diff

Attachments on bug 194821: 362400