Attachment 362347 Details for Bug 193599 – To land

[patch] To land

bug-193599-20190218152043.patch (text/plain), 21.76 KB, created by Daniel Bates on 2019-02-18 15:20:44 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2019-02-18 15:20:44 PST

Size: 21.76 KB

patch

obsolete

>Subversion Revision: 241743
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 5bcf3f411d0e5bf9c5df682fb93b5f924704043a..88cf9487afcc357277d5b213440a8357b49231de 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,35 @@
>+2019-02-18  Daniel Bates  <dabates@apple.com>
>+
>+        [iOS] Focus ring for checkboxes, radio buttons, buttons and search fields should hug tighter to the contour
>+        https://bugs.webkit.org/show_bug.cgi?id=193599
>+        <rdar://problem/47399602>
>+
>+        Reviewed by Simon Fraser.
>+
>+        For now, iOS uses a 3px outline width for its focus rings. Do not inset the focus ring on iOS
>+        for text fields, textareas, keygens, and selects so as to match the visual appearance of all
>+        the other controls.
>+
>+        Tests: fast/forms/ios/focus-button.html
>+               fast/forms/ios/focus-checkbox.html
>+               fast/forms/ios/focus-checked-checkbox.html
>+               fast/forms/ios/focus-checked-radio.html
>+               fast/forms/ios/focus-radio.html
>+               fast/forms/ios/focus-reset-button.html
>+               fast/forms/ios/focus-search-field.html
>+               fast/forms/ios/focus-submit-button.html
>+               fast/forms/ios/focus-text-field.html
>+               fast/forms/ios/focus-textarea.html
>+
>+        * css/html.css:
>+        (:focus): Use 3px outline width.
>+        (input:focus, textarea:focus, keygen:focus, select:focus): Guard this code to exclude it when building for iOS.
>+        * rendering/RenderBox.cpp:
>+        (WebCore::RenderBox::paintBoxDecorations): Add FIXME comment.
>+        * rendering/RenderElement.cpp:
>+        (WebCore::RenderElement::paintOutline): Call RenderTheme::adjustPaintRect() to adjust the paint rect.
>+        Otherwise, the focus rings for radios and checkboxes are drawn at the wrong y-coordinate and are not snug.
>+
> 2019-02-18  John Wilander  <wilander@apple.com>
> 
>         Check the existence of the frame in Document::hasFrameSpecificStorageAccess() and Document::setHasFrameSpecificStorageAccess()
>diff --git a/Source/WebCore/css/html.css b/Source/WebCore/css/html.css
>index 4c25559b02c40c385592e5ae808ba6cf45551d25..6992145fe4df91debe6d1f754080469dafcbe86c 100644
>--- a/Source/WebCore/css/html.css
>+++ b/Source/WebCore/css/html.css
>@@ -1162,7 +1162,11 @@ nobr {
> /* states */
> 
> :focus {
>+#if defined(WTF_PLATFORM_IOS_FAMILY) && WTF_PLATFORM_IOS_FAMILY
>+    outline: auto 3px -webkit-focus-ring-color;
>+#else
>     outline: auto 5px -webkit-focus-ring-color;
>+#endif
> }
> 
> /* Read-only text fields do not show a focus ring but do still receive focus */
>@@ -1170,9 +1174,11 @@ html:focus, body:focus, input[readonly]:focus, applet:focus, embed:focus, iframe
>     outline: none;
> }
> 
>+#if !defined(WTF_PLATFORM_IOS_FAMILY) || !WTF_PLATFORM_IOS_FAMILY
> input:focus, textarea:focus, keygen:focus, select:focus {
>     outline-offset: -2px;
> }
>+#endif
> 
> input:matches([type="button"], [type="checkbox"], [type="file"], [type="hidden"], [type="image"], [type="radio"], [type="reset"], [type="search"], [type="submit"]):focus,
> input[type="file"]:focus::-webkit-file-upload-button {
>diff --git a/Source/WebCore/rendering/RenderBox.cpp b/Source/WebCore/rendering/RenderBox.cpp
>index 7bd279b06dd0d46e8a2ff91dee68fca3b938cfc4..24f208d7ea1421355572d2485db37f9412302960 100644
>--- a/Source/WebCore/rendering/RenderBox.cpp
>+++ b/Source/WebCore/rendering/RenderBox.cpp
>@@ -1302,10 +1302,11 @@ void RenderBox::paintBoxDecorations(PaintInfo& paintInfo, const LayoutPoint& pai
> 
> #if PLATFORM(IOS_FAMILY)
>     // Workaround for <rdar://problem/6209763>. Force the painting bounds of checkboxes and radio controls to be square.
>+    // FIXME: Consolidate this code with the same code in RenderElement::paintOutline(). See <https://bugs.webkit.org/show_bug.cgi?id=194781>.
>     if (style().appearance() == CheckboxPart || style().appearance() == RadioPart) {
>         int width = std::min(paintRect.width(), paintRect.height());
>         int height = width;
>-        paintRect = IntRect(paintRect.x(), paintRect.y() + (this->height() - height) / 2, width, height); // Vertically center the checkbox, like on desktop
>+        paintRect = IntRect { paintRect.x(), paintRect.y() + (this->height() - height) / 2, width, height }; // Vertically center the checkbox, like on desktop
>     }
> #endif
>     BackgroundBleedAvoidance bleedAvoidance = determineBackgroundBleedAvoidance(paintInfo.context());
>diff --git a/Source/WebCore/rendering/RenderElement.cpp b/Source/WebCore/rendering/RenderElement.cpp
>index 96d4a3c2abfc1562aaf023f2d47d05fa66ef6a3c..022fe3ba00fbd611161a7142d92aed9a6539b2ef 100644
>--- a/Source/WebCore/rendering/RenderElement.cpp
>+++ b/Source/WebCore/rendering/RenderElement.cpp
>@@ -1896,7 +1896,17 @@ void RenderElement::paintOutline(PaintInfo& paintInfo, const LayoutRect& paintRe
>     // Only paint the focus ring by hand if the theme isn't able to draw it.
>     if (styleToUse.outlineStyleIsAuto() == OutlineIsAuto::On && !theme().supportsFocusRing(styleToUse)) {
>         Vector<LayoutRect> focusRingRects;
>-        addFocusRingRects(focusRingRects, paintRect.location(), paintInfo.paintContainer);
>+        LayoutRect paintRectToUse { paintRect };
>+#if PLATFORM(IOS_FAMILY)
>+        // Workaround for <rdar://problem/6209763>. Force the painting bounds of checkboxes and radio controls to be square.
>+        // FIXME: Consolidate this code with the same code in RenderBox::paintBoxDecorations(). See <https://bugs.webkit.org/show_bug.cgi?id=194781>.
>+        if (style().appearance() == CheckboxPart || style().appearance() == RadioPart) {
>+            int width = std::min(paintRect.width(), paintRect.height());
>+            int height = width;
>+            paintRectToUse = IntRect { paintRect.x(), paintRect.y() + (downcast<RenderBox>(*this).height() - height) / 2, width, height }; // Vertically center the checkbox, like on desktop
>+        }
>+#endif
>+        addFocusRingRects(focusRingRects, paintRectToUse.location(), paintInfo.paintContainer);
>         paintFocusRing(paintInfo, styleToUse, focusRingRects);
>     }
> 
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index e3cac30284cfda83d2a61e58e9eb9689c8a4e02d..589a9cde734aefb13459124ad14e6e9505a89f6f 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,40 @@
>+2019-02-18  Daniel Bates  <dabates@apple.com>
>+
>+        [iOS] Focus ring for checkboxes, radio buttons, buttons and search fields should hug tighter to the contour
>+        https://bugs.webkit.org/show_bug.cgi?id=193599
>+        <rdar://problem/47399602>
>+
>+        Reviewed by Simon Fraser.
>+
>+        Ideally we should find a way to write non-pixel tests for focus rings. For now, add some mismatch ref
>+        tests.
>+
>+        We cannot write a "good" mismatch ref test for <select> at the moment since there is no way to defocus
>+        a <select> without closing its popup. We also cannot change outline-color when outline-style: auto is
>+        used and outline-style: auto is needed to get shrink-wrapped focus rings :(
>+
>+        * fast/forms/ios/focus-button-expected-mismatch.html: Added.
>+        * fast/forms/ios/focus-button.html: Added.
>+        * fast/forms/ios/focus-checkbox-expected-mismatch.html: Added.
>+        * fast/forms/ios/focus-checkbox.html: Added.
>+        * fast/forms/ios/focus-checked-checkbox-expected-mismatch.html: Added.
>+        * fast/forms/ios/focus-checked-checkbox.html: Added.
>+        * fast/forms/ios/focus-checked-radio-expected-mismatch.html: Added.
>+        * fast/forms/ios/focus-checked-radio.html: Added.
>+        * fast/forms/ios/focus-radio-expected-mismatch.html: Added.
>+        * fast/forms/ios/focus-radio.html: Added.
>+        * fast/forms/ios/focus-reset-button-expected-mismatch.html: Added.
>+        * fast/forms/ios/focus-reset-button.html: Added.
>+        * fast/forms/ios/focus-search-field-expected-mismatch.html: Added.
>+        * fast/forms/ios/focus-search-field.html: Added.
>+        * fast/forms/ios/focus-submit-button-expected-mismatch.html: Added.
>+        * fast/forms/ios/focus-submit-button.html: Added.
>+        * fast/forms/ios/focus-text-field-expected-mismatch.html: Added.
>+        * fast/forms/ios/focus-text-field.html: Added.
>+        * fast/forms/ios/focus-textarea-expected-mismatch.html: Added.
>+        * fast/forms/ios/focus-textarea.html: Added.
>+        * platform/ios/TestExpectations: Skip the tests for now on iOS we do not build with ENABLE(FULL_KEYBOARD_ACCESS) enabled.
>+
> 2019-02-18  John Wilander  <wilander@apple.com>
> 
>         Check the existence of the frame in Document::hasFrameSpecificStorageAccess() and Document::setHasFrameSpecificStorageAccess()
>diff --git a/LayoutTests/fast/forms/ios/focus-button-expected-mismatch.html b/LayoutTests/fast/forms/ios/focus-button-expected-mismatch.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..d9363b0fded7add2bf4a3653e350ee78cf6ea558
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-button-expected-mismatch.html
>@@ -0,0 +1,6 @@
>+<!DOCTYPE html>
>+<html>
>+<body>
>+<button>Button</button>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-button.html b/LayoutTests/fast/forms/ios/focus-button.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..2bb0a85c6fdeff7b9ec98a41d18d82649a3c6f0b
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-button.html
>@@ -0,0 +1,17 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<script src="../../resources/ui-helper.js"></script>
>+</head>
>+<body>
>+<button id="test">Button</button> 
>+<script>
>+if (window.testRunner) {
>+    testRunner.waitUntilDone();
>+    let testElement = document.getElementById("test");
>+    testElement.addEventListener("focus", () => testRunner.notifyDone(), { once: true });
>+    UIHelper.keyDown("\t", ["altKey"]);
>+}
>+</script>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-checkbox-expected-mismatch.html b/LayoutTests/fast/forms/ios/focus-checkbox-expected-mismatch.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..441ee3c035e265056117666d2713842a58c8156b
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-checkbox-expected-mismatch.html
>@@ -0,0 +1,6 @@
>+<!DOCTYPE html>
>+<html>
>+<body>
>+<input type="checkbox">
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-checkbox.html b/LayoutTests/fast/forms/ios/focus-checkbox.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..c590c873bc04d4d165ef5973ec56a087d6bd76fd
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-checkbox.html
>@@ -0,0 +1,17 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<script src="../../resources/ui-helper.js"></script>
>+</head>
>+<body>
>+<input id="test" type="checkbox"> 
>+<script>
>+if (window.testRunner) {
>+    testRunner.waitUntilDone();
>+    let testElement = document.getElementById("test");
>+    testElement.addEventListener("focus", () => testRunner.notifyDone(), { once: true });
>+    UIHelper.keyDown("\t", ["altKey"]);
>+}
>+</script>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-checked-checkbox-expected-mismatch.html b/LayoutTests/fast/forms/ios/focus-checked-checkbox-expected-mismatch.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..8a4383df9758c0c310a5989f2ff237449eb8a4b3
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-checked-checkbox-expected-mismatch.html
>@@ -0,0 +1,6 @@
>+<!DOCTYPE html>
>+<html>
>+<body>
>+<input type="checkbox" checked>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-checked-checkbox.html b/LayoutTests/fast/forms/ios/focus-checked-checkbox.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..75813da757313ee5de3ee619b740a83a28f57aa1
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-checked-checkbox.html
>@@ -0,0 +1,17 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<script src="../../resources/ui-helper.js"></script>
>+</head>
>+<body>
>+<input id="test" type="checkbox" checked> 
>+<script>
>+if (window.testRunner) {
>+    testRunner.waitUntilDone();
>+    let testElement = document.getElementById("test");
>+    testElement.addEventListener("focus", () => testRunner.notifyDone(), { once: true });
>+    UIHelper.keyDown("\t", ["altKey"]);
>+}
>+</script>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-checked-radio-expected-mismatch.html b/LayoutTests/fast/forms/ios/focus-checked-radio-expected-mismatch.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..00766deb1431a398eed1c55c455b288bb71b395c
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-checked-radio-expected-mismatch.html
>@@ -0,0 +1,6 @@
>+<!DOCTYPE html>
>+<html>
>+<body>
>+<input type="radio" checked>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-checked-radio.html b/LayoutTests/fast/forms/ios/focus-checked-radio.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..4924d32ac61b6fcb4040508ac399f067292b4c91
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-checked-radio.html
>@@ -0,0 +1,17 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<script src="../../resources/ui-helper.js"></script>
>+</head>
>+<body>
>+<input id="test" type="radio" checked> 
>+<script>
>+if (window.testRunner) {
>+    testRunner.waitUntilDone();
>+    let testElement = document.getElementById("test");
>+    testElement.addEventListener("focus", () => testRunner.notifyDone(), { once: true });
>+    UIHelper.keyDown("\t", ["altKey"]);
>+}
>+</script>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-radio-expected-mismatch.html b/LayoutTests/fast/forms/ios/focus-radio-expected-mismatch.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..4f07a7797a8696539d06942b654475a081f1aa96
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-radio-expected-mismatch.html
>@@ -0,0 +1,6 @@
>+<!DOCTYPE html>
>+<html>
>+<body>
>+<input type="radio">
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-radio.html b/LayoutTests/fast/forms/ios/focus-radio.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..09af6a07853a857f1ae0fc2de9235f1f14f00944
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-radio.html
>@@ -0,0 +1,17 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<script src="../../resources/ui-helper.js"></script>
>+</head>
>+<body>
>+<input id="test" type="radio"> 
>+<script>
>+if (window.testRunner) {
>+    testRunner.waitUntilDone();
>+    let testElement = document.getElementById("test");
>+    testElement.addEventListener("focus", () => testRunner.notifyDone(), { once: true });
>+    UIHelper.keyDown("\t", ["altKey"]);
>+}
>+</script>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-reset-button-expected-mismatch.html b/LayoutTests/fast/forms/ios/focus-reset-button-expected-mismatch.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..871d2fc242c1fe1cfb6519a47d8238151d232718
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-reset-button-expected-mismatch.html
>@@ -0,0 +1,6 @@
>+<!DOCTYPE html>
>+<html>
>+<body>
>+<input type="reset">
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-reset-button.html b/LayoutTests/fast/forms/ios/focus-reset-button.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..6aac0abf1e53c99176ab47ad6e1ba3683bfff941
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-reset-button.html
>@@ -0,0 +1,17 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<script src="../../resources/ui-helper.js"></script>
>+</head>
>+<body>
>+<input id="test" type="reset"> 
>+<script>
>+if (window.testRunner) {
>+    testRunner.waitUntilDone();
>+    let testElement = document.getElementById("test");
>+    testElement.addEventListener("focus", () => testRunner.notifyDone(), { once: true });
>+    UIHelper.keyDown("\t", ["altKey"]);
>+}
>+</script>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-search-field-expected-mismatch.html b/LayoutTests/fast/forms/ios/focus-search-field-expected-mismatch.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..934722bc03bbb327b8ac063028855d1d955f4b4e
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-search-field-expected-mismatch.html
>@@ -0,0 +1,6 @@
>+<!DOCTYPE html>
>+<html>
>+<body>
>+<input type="search">
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-search-field.html b/LayoutTests/fast/forms/ios/focus-search-field.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..c2cc669a507f8bc3f5b0992c61392e5c4ab971b9
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-search-field.html
>@@ -0,0 +1,22 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<script src="../../resources/ui-helper.js"></script>
>+<style>
>+input {
>+    caret-color: transparent;
>+}
>+</style>
>+</head>
>+<body>
>+<input id="test" type="search"> 
>+<script>
>+if (window.testRunner) {
>+    testRunner.waitUntilDone();
>+    let testElement = document.getElementById("test");
>+    testElement.addEventListener("focus", () => testRunner.notifyDone(), { once: true });
>+    UIHelper.keyDown("\t", ["altKey"]);
>+}
>+</script>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-submit-button-expected-mismatch.html b/LayoutTests/fast/forms/ios/focus-submit-button-expected-mismatch.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..e648275d6542f88a6c7d23f36e737b29c2f9c0cb
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-submit-button-expected-mismatch.html
>@@ -0,0 +1,6 @@
>+<!DOCTYPE html>
>+<html>
>+<body>
>+<input type="submit">
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-submit-button.html b/LayoutTests/fast/forms/ios/focus-submit-button.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..70fd07565d6636b49ae0d30818f771bdc4c1024e
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-submit-button.html
>@@ -0,0 +1,17 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<script src="../../resources/ui-helper.js"></script>
>+</head>
>+<body>
>+<input id="test" type="submit"> 
>+<script>
>+if (window.testRunner) {
>+    testRunner.waitUntilDone();
>+    let testElement = document.getElementById("test");
>+    testElement.addEventListener("focus", () => testRunner.notifyDone(), { once: true });
>+    UIHelper.keyDown("\t", ["altKey"]);
>+}
>+</script>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-text-field-expected-mismatch.html b/LayoutTests/fast/forms/ios/focus-text-field-expected-mismatch.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..5008bfbeed9533278e9d960525276b8c8968f939
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-text-field-expected-mismatch.html
>@@ -0,0 +1,6 @@
>+<!DOCTYPE html>
>+<html>
>+<body>
>+<input type="text">
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-text-field.html b/LayoutTests/fast/forms/ios/focus-text-field.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..1de76e4c9a4baad09bb9f68963befc25c93930b1
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-text-field.html
>@@ -0,0 +1,22 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<script src="../../resources/ui-helper.js"></script>
>+<style>
>+input {
>+    caret-color: transparent;
>+}
>+</style>
>+</head>
>+<body>
>+<input id="test" type="text"> 
>+<script>
>+if (window.testRunner) {
>+    testRunner.waitUntilDone();
>+    let testElement = document.getElementById("test");
>+    testElement.addEventListener("focus", () => testRunner.notifyDone(), { once: true });
>+    UIHelper.keyDown("\t", ["altKey"]);
>+}
>+</script>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-textarea-expected-mismatch.html b/LayoutTests/fast/forms/ios/focus-textarea-expected-mismatch.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..0d83e68c2d21525a92db68f27a3f20ca866228c3
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-textarea-expected-mismatch.html
>@@ -0,0 +1,6 @@
>+<!DOCTYPE html>
>+<html>
>+<body>
>+<textarea></textarea>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/forms/ios/focus-textarea.html b/LayoutTests/fast/forms/ios/focus-textarea.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..7c67d938ece1b1afb1a7c8330f9cbe4a54456271
>--- /dev/null
>+++ b/LayoutTests/fast/forms/ios/focus-textarea.html
>@@ -0,0 +1,22 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<script src="../../resources/ui-helper.js"></script>
>+<style>
>+textarea {
>+    caret-color: transparent;
>+}
>+</style>
>+</head>
>+<body>
>+<textarea id="test"></textarea> 
>+<script>
>+if (window.testRunner) {
>+    testRunner.waitUntilDone();
>+    let testElement = document.getElementById("test");
>+    testElement.addEventListener("focus", () => testRunner.notifyDone(), { once: true });
>+    UIHelper.keyDown("\t", ["altKey"]);
>+}
>+</script>
>+</body>
>+</html>
>diff --git a/LayoutTests/platform/ios/TestExpectations b/LayoutTests/platform/ios/TestExpectations
>index db52d67b416ea761f6dbd8753962bd94d165aada..a96704354ce8bc637077d8525656d60cbf19c35d 100644
>--- a/LayoutTests/platform/ios/TestExpectations
>+++ b/LayoutTests/platform/ios/TestExpectations
>@@ -3218,3 +3218,15 @@ fast/events/touch/ios/pointer-events-with-modifiers.html [ Skip ]
> # FIXME: Unskip the following test once we have the fix for <rdar://problem/44928156>.
> fast/events/ios/key-command-delete-to-end-of-paragraph.html [ Skip ]
> fast/events/ios/key-command-transpose.html [ Skip ]
>+
>+# FIXME: Unskip the following tests once we ENABLE(FULL_KEYBOARD_ACCESS) is enabled by default on iOS
>+fast/forms/ios/focus-button.html [ Skip ]
>+fast/forms/ios/focus-checkbox.html [ Skip ]
>+fast/forms/ios/focus-checked-checkbox.html [ Skip ]
>+fast/forms/ios/focus-checked-radio.html [ Skip ]
>+fast/forms/ios/focus-radio.html [ Skip ]
>+fast/forms/ios/focus-reset-button.html [ Skip ]
>+fast/forms/ios/focus-search-field.html [ Skip ]
>+fast/forms/ios/focus-submit-button.html [ Skip ]
>+fast/forms/ios/focus-text-field.html [ Skip ]
>+fast/forms/ios/focus-textarea.html [ Skip ]

Actions: View | Formatted Diff | Diff

Attachments on bug 193599: 362302 | 362307 | 362311 | 362312 | 362330 | 362333 | 362344 | 362347