Attachment 362340 Details for Bug 191988 – Patch for landing

[patch] Patch for landing

bug-191988-20190218145212.patch (text/plain), 1.77 KB, created by Jer Noble on 2019-02-18 14:52:13 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2019-02-18 14:52:13 PST

Size: 1.77 KB

patch

obsolete

>Subversion Revision: 241740
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 8be06a7ce10021514685b4a64864a48b8d20be1c..228ea0666efd9185bb39a046de60eef3512f8e34 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-02-18  Jeremy Jones  <jeremyj@apple.com>
>+
>+        exitFullscreen should not instantiate a new model/interface mapping.
>+        https://bugs.webkit.org/show_bug.cgi?id=191988
>+        rdar://problem/42327939
>+
>+        Reviewed by Jer Noble.
>+
>+        This change is a speculative fix for a crash that cannot be reproduced.
>+
>+        Somehow, exitFullscreen is being requested after didCleanupFullscreen has completed.
>+        This change should allow us to prevent the crash in release, and assert in debug.
>+
>+        * UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
>+        (WebKit::VideoFullscreenManagerProxy::exitFullscreen):
>+
> 2019-02-18  Per Arne Vollan  <pvollan@apple.com>
> 
>         It should be possible to get the mouse event modifiers for a page overlay client.
>diff --git a/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm b/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm
>index 4cf30bf331e79421f239cca596311392f8f5a833..cc6037d007b58a11a149e8e04ed4c5bf0b599f38 100644
>--- a/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm
>+++ b/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm
>@@ -531,6 +531,10 @@ void VideoFullscreenManagerProxy::enterFullscreen(uint64_t contextId)
> 
> void VideoFullscreenManagerProxy::exitFullscreen(uint64_t contextId, WebCore::IntRect finalRect)
> {
>+    ASSERT(m_contextMap.contains(contextId));
>+    if (!m_contextMap.contains(contextId))
>+        return;
>+
> #if PLATFORM(IOS_FAMILY)
>     ensureInterface(contextId).exitFullscreen(finalRect);
> #else

Actions: View | Formatted Diff | Diff

Attachments on bug 191988: 355690 | 362340