Attachment 362337 Details for Bug 194792 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

console-1.patch (text/plain), 1.62 KB, created by Joseph Pecoraro on 2019-02-18 14:49:39 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-02-18 14:49:39 PST

Size: 1.62 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index b9c48f18826..ed809cbef09 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-02-18  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Fix a typo causing assertions in ConsoleManager
>+        https://bugs.webkit.org/show_bug.cgi?id=194792
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Controllers/ConsoleManager.js:
>+        (WI.ConsoleManager.prototype.initializeLogChannels):
>+        Extra comma produced an undefined value in the list.
>+
> 2019-02-15  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: Improve ES6 Class instances in Heap Snapshot instances view
>diff --git a/Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js b/Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js
>index 52f72a4f3bf..605702177e2 100644
>--- a/Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js
>+++ b/Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js
>@@ -160,7 +160,7 @@ WI.ConsoleManager = class ConsoleManager extends WI.Object
>         if (this._loggingChannelSources.length)
>             return;
> 
>-        this._loggingChannelSources = [WI.ConsoleMessage.MessageSource.Media, WI.ConsoleMessage.MessageSource.WebRTC, , WI.ConsoleMessage.MessageSource.MessageSource];
>+        this._loggingChannelSources = [WI.ConsoleMessage.MessageSource.Media, WI.ConsoleMessage.MessageSource.WebRTC, WI.ConsoleMessage.MessageSource.MessageSource];
> 
>         target.ConsoleAgent.getLoggingChannels((error, channels) => {
>             if (error)

Actions: View | Formatted Diff | Diff

Attachments on bug 194792: 362337