Attachment 362329 Details for Bug 194789 – Patch

[patch] Patch

patch.txt (text/plain), 2.13 KB, created by Nikita Vasilyev on 2019-02-18 14:02:56 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2019-02-18 14:02:56 PST

Size: 2.13 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index c08f51c9a09..71d3b7a2d10 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-02-18  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Styles: typing ";" shouldn't focus on the next property when there's open parenthesis or comment
>+        https://bugs.webkit.org/show_bug.cgi?id=194789
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/SpreadsheetStyleProperty.js:
>+        (WI.SpreadsheetStyleProperty.prototype._handleValueBeforeInput):
>+
> 2019-02-17  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Move CSS completion logic from SpreadsheetTextField to SpreadsheetStyleProperty
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>index 24948512b34..5e0853a4793 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>@@ -727,20 +727,8 @@ WI.SpreadsheetStyleProperty = class SpreadsheetStyleProperty extends WI.Object
>         if (!selection.rangeCount || selection.getRangeAt(0).endOffset !== text.length)
>             return;
> 
>-        // Find the first and last index (if any) of a quote character to ensure that the string
>-        // doesn't contain unbalanced quotes. If so, then there's no way that the semicolon could be
>-        // part of a string within the value, so we can assume that it's the property "terminator".
>-        const quoteRegex = /["']/g;
>-        let start = -1;
>-        let end = text.length;
>-        let match = null;
>-        while (match = quoteRegex.exec(text)) {
>-            if (start < 0)
>-                start = match.index;
>-            end = match.index + 1;
>-        }
>-
>-        if (start !== -1 && !text.substring(start, end).hasMatchingEscapedQuotes())
>+        let unbalancedCharacters = WI.CSSCompletions.completeUnbalancedValue(text);
>+        if (unbalancedCharacters)
>             return;
> 
>         event.preventDefault();

Actions: View | Formatted Diff | Diff

Attachments on bug 194789: 362329