Attachment 362304 Details for Bug 194782 – Patch

[patch] Patch

bug-194782-20190218110233.patch (text/plain), 4.29 KB, created by Devin Rousso on 2019-02-18 11:02:33 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-02-18 11:02:33 PST

Size: 4.29 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 1904dbe789f33ded2d6a0d12d738c634626d2d5d..16dee6c93e911c8a7a428e7cf860623f1b515c54 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-02-18  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: duplicate left double quotation mark (\u201C) in 'Unable to show certificate for â%sâ.'
>+        https://bugs.webkit.org/show_bug.cgi?id=194782
>+        <rdar://problem/48159683>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Models/Resource.js:
>+        (WI.Resource.prototype.async showCertificate):
>+        * Localizations/en.lproj/localizedStrings.js:
>+
> 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
> 
>         Add MSE logging configuration
>diff --git a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>index a2b113e172a587d730ad9af70a81ed438d99ef2a..020c043cf2021ea40a75b21d24fa893ea22bc225 100644
>--- a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>+++ b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>@@ -372,6 +372,7 @@ localizedStrings["Element is the root element"] = "Element is the root element";
> localizedStrings["Element may overlap another compositing element"] = "Element may overlap another compositing element";
> localizedStrings["Element overlaps other compositing element"] = "Element overlaps other compositing element";
> localizedStrings["Elements"] = "Elements";
>+localizedStrings["Emulate User Gesture"] = "Emulate User Gesture";
> localizedStrings["Enable Breakpoint"] = "Enable Breakpoint";
> localizedStrings["Enable Breakpoints"] = "Enable Breakpoints";
> localizedStrings["Enable Event Listener"] = "Enable Event Listener";
>@@ -413,7 +414,6 @@ localizedStrings["Event Dispatched"] = "Event Dispatched";
> localizedStrings["Event Listeners"] = "Event Listeners";
> localizedStrings["Events"] = "Events";
> localizedStrings["Example: \u201C%s\u201D"] = "Example: \u201C%s\u201D";
>-localizedStrings["Emulate User Gesture"] = "Emulate User Gesture";
> localizedStrings["Exception with thrown value: %s"] = "Exception with thrown value: %s";
> localizedStrings["Exited Full-Screen Mode"] = "Exited Full-Screen Mode";
> localizedStrings["Exited Low-Power Mode"] = "Exited Low-Power Mode";
>@@ -462,7 +462,6 @@ localizedStrings["Format: RGB"] = "Format: RGB";
> localizedStrings["Format: RGBA"] = "Format: RGBA";
> localizedStrings["Format: Short Hex"] = "Format: Short Hex";
> localizedStrings["Format: Short Hex with Alpha"] = "Format: Short Hex with Alpha";
>-localizedStrings["Forms"] = "Forms";
> localizedStrings["Forward (%s)"] = "Forward (%s)";
> localizedStrings["Fragment"] = "Fragment";
> localizedStrings["Fragment Shader"] = "Fragment Shader";
>@@ -1021,7 +1020,7 @@ localizedStrings["URL"] = "URL";
> localizedStrings["URL Breakpoint\u2026"] = "URL Breakpoint\u2026";
> localizedStrings["Unable to determine path to property from root"] = "Unable to determine path to property from root";
> localizedStrings["Unable to parse as JSON: %s"] = "Unable to parse as JSON: %s";
>-localizedStrings["Unable to show certificate for \u201C%s\u201C"] = "Unable to show certificate for \u201C%s\u201C";
>+localizedStrings["Unable to show certificate for \u201C%s\u201D"] = "Unable to show certificate for \u201C%s\u201D";
> localizedStrings["Uncaught Exceptions"] = "Uncaught Exceptions";
> localizedStrings["Undefined custom element"] = "Undefined custom element";
> localizedStrings["Unique"] = "Unique";
>diff --git a/Source/WebInspectorUI/UserInterface/Models/Resource.js b/Source/WebInspectorUI/UserInterface/Models/Resource.js
>index 0d8714595082f0b2087bdbba3586309c935a49b8..38ae1d9f4c8202400a4b449ff25af08e6c311f05 100644
>--- a/Source/WebInspectorUI/UserInterface/Models/Resource.js
>+++ b/Source/WebInspectorUI/UserInterface/Models/Resource.js
>@@ -1111,7 +1111,7 @@ WI.Resource = class Resource extends WI.SourceCode
> 
>     async showCertificate()
>     {
>-        let errorString = WI.UIString("Unable to show certificate for \u201C%s\u201C").format(this.url);
>+        let errorString = WI.UIString("Unable to show certificate for \u201C%s\u201D").format(this.url);
> 
>         try {
>             let {serializedCertificate} = await NetworkAgent.getSerializedCertificate(this._requestIdentifier);

Actions: View | Formatted Diff | Diff

Attachments on bug 194782: 362304