Attachment 362301 Details for Bug 194777 – Patch

[patch] Patch

bug-194777-20190218091611.patch (text/plain), 1.86 KB, created by John Wilander on 2019-02-18 09:16:11 PST

(hide)

Description:

Filename:

MIME Type:

Creator: John Wilander

Created: 2019-02-18 09:16:11 PST

Size: 1.86 KB

patch

obsolete

>Subversion Revision: 241662
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2141a8fc3dfb31427975501667bd3751a04b2ce6..f5e51cf59d2bf289902ff9f74e8106ffb9670abb 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-02-18  John Wilander  <wilander@apple.com>
>+
>+        Check the existence of the frame in Document::hasFrameSpecificStorageAccess() and Document::setHasFrameSpecificStorageAccess()
>+        https://bugs.webkit.org/show_bug.cgi?id=194777
>+        <rdar://problem/47731945>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests.
>+
>+        * dom/Document.cpp:
>+        (WebCore::Document::hasFrameSpecificStorageAccess const):
>+            Now checks for the existence of the frame.
>+        (WebCore::Document::setHasFrameSpecificStorageAccess):
>+            Now checks for the existence of the frame.
>+
> 2019-02-17  David Kilzer  <ddkilzer@apple.com>
> 
>         Unreviewed, rolling out r241620.
>diff --git a/Source/WebCore/dom/Document.cpp b/Source/WebCore/dom/Document.cpp
>index 050555ba9491f47ca0bb4dfdaaa193d9ac54edf9..416ffe0ff19bdd5ff4e9d33ded85c111700d2dd6 100644
>--- a/Source/WebCore/dom/Document.cpp
>+++ b/Source/WebCore/dom/Document.cpp
>@@ -8458,12 +8458,13 @@ void Document::updateMainArticleElementAfterLayout()
> #if ENABLE(RESOURCE_LOAD_STATISTICS)
> bool Document::hasFrameSpecificStorageAccess() const
> {
>-    return m_frame->loader().client().hasFrameSpecificStorageAccess();
>+    return m_frame && m_frame->loader().client().hasFrameSpecificStorageAccess();
> }
>     
> void Document::setHasFrameSpecificStorageAccess(bool value)
> {
>-    m_frame->loader().client().setHasFrameSpecificStorageAccess(value);
>+    if (m_frame)
>+        m_frame->loader().client().setHasFrameSpecificStorageAccess(value);
> }
> 
> bool Document::hasRequestedPageSpecificStorageAccessWithUserInteraction(const String& primaryDomain)

Actions: View | Formatted Diff | Diff

Attachments on bug 194777: 362301 | 362321 | 362335