Attachment 362262 Details for Bug 194763 – Proposed patch

[patch] Proposed patch

review-policy-r-2.patch (text/plain), 1.79 KB, created by Aakash Jain on 2019-02-17 17:07:56 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-02-17 17:07:56 PST

Size: 1.79 KB

patch

obsolete

>Index: Websites/webkit.org/ChangeLog
>===================================================================
>--- Websites/webkit.org/ChangeLog	(revision 241651)
>+++ Websites/webkit.org/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2019-02-17  Aakash Jain  <aakash_jain@apple.com>
>+
>+        Update WebKit review policy to allow r- by non-reviewers
>+        https://bugs.webkit.org/show_bug.cgi?id=194763
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * commit-review.md:
>+
> 2019-02-07  Jon Davis  <jond@apple.com>
> 
>         Fixed animation positioning when homepage animation completes
>Index: Websites/webkit.org/commit-review.md
>===================================================================
>--- Websites/webkit.org/commit-review.md	(revision 241651)
>+++ Websites/webkit.org/commit-review.md	(working copy)
>@@ -30,7 +30,7 @@ A WebKit Reviewer should be a person who
> 
> A potential Reviewer may be nominated once they have submitted a minimum of 80 good patches. They should also be in touch with other reviewers and aware of who are the experts in various areas.
> 
>-A person who submits many patches but does not show good collaboration skills, code understanding or understanding of project policies may never be nominated. Making unofficial reviews before you become a reviewer is encouraged. This is an excellent way to show your skills. Note that you should not put r+ nor r- on patches in such unofficial reviews.
>+A person who submits many patches but does not show good collaboration skills, code understanding or understanding of project policies may never be nominated. Making unofficial reviews before you become a reviewer is encouraged. This is an excellent way to show your skills. Note that you should not put r+ on patches in such unofficial reviews.
> 
> For Reviewer status, there is no supervision exception.
>

Flags:

sam: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 194763: 362262